Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve developer experience with finding and comparing mock requests #2348

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Improve developer experience with finding and comparing mock requests #2348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d91691
trace original request in mock data, allow comparison
volodymyrss Mar 29, 2022
3ff806d
delete dat
volodymyrss Mar 29, 2022
5b2a969
cena
volodymyrss Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion astroquery/heasarc/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ def query_region_async(self, position: Union[coordinates.SkyCoord, str],
# Generate the request
request_payload = self._args_to_payload(
mission=mission,
entry="{},{}".format(c.ra.degree, c.dec.degree),
entry="{:.10f},{:.10f}".format(c.ra.degree, c.dec.degree),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just an aside, this is in PR #2347 - so that should be merged first, then this will disappear from the diff

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's right. I meant this one to be merged after #2347 .

radius=u.Quantity(radius),
**kwargs
)
Expand Down
1,001 changes: 0 additions & 1,001 deletions astroquery/heasarc/tests/data/0f36aba7.dat
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions astroquery/heasarc/tests/data/10f92917.json
View file
Open in desktop

Large diffs are not rendered by default.

64 changes: 0 additions & 64 deletions astroquery/heasarc/tests/data/157a5015.dat
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions astroquery/heasarc/tests/data/157a5015.json
View file
Open in desktop

Large diffs are not rendered by default.

Loading