update imaging url for dr18

update change log add fixes for sdss/boss/eboss spectra URLs use named groups add temporary warning add initial test for download URLs testing the image url test remove null table ensure no downloads fix test ordering add tests for spectra fix column lengths fix test function fix key error test eFEDS urls fix style error make sure plate is really the same fix url test reactivate some xfail tests. test downloading eFEDS spectra fix style error fix style clean-up prior to merge Enhanced results feature in ALMA append filename to local path Update docs Parse a directory or filename style fixes update changes file Added pull request number to changes clean up test artifacts create dir if it does not exist Update VSA url Adding changelog [skip ci] Added support for spectral_resolution in ALMA Reduce execution time of remote test suite Modulate verbosity on download_products() function style fixes Update changes file Add check to test case TST: skipping test when dependency is missing MAINT: raise exception for missing dependency DOC: fixing failing doctest examples TST: adding new datarelease MAINT: update mailmap MAINT: update licence year MAINT: remove deprecated usage of BeautifulSoup CI: separate out online tests to their own workflow MAINT: skipping bigdata marked tests in CI TST: marking a 800+Mb alma test bigdata MAINT: fix OGLE url DOC: add changelog MAINT: adding doctesting dependency for cloud example TST: don't test defunct module DOC: minor doc example fixes MAINT: fixing changed astropy API for test MAINT: fix python deprecation TST: Catch one more warning in test TST: various minor doctest fixes maint: allow doctests in doc switched to a more specific example than kang 51 because there are often new catalogs matching this maint: switch to tests with less data to download maint: switch from meta.all to meta to reduce response size we don't lose information, but ASU-style queries cannot get a dictionnary in the POST request's data refactor: switch to public API in remote tests refactor: simbad query methods now call query_tap internally - add construct_query method that reads the columns_in_output, join, and criteria attirbutes - support the removed query_criteria method functionnalities by adding a criteria attribute that should be a valid adql clause. The utils CriteriaTranslator can translate between the old and new syntax. - make ROW_LIMIT = -1 to return all lines because TOP 0 or maxrec = 0 are the dedicated way to retrieve table metadata in TAP - fix usage of lru_cache on class methods that can cause memory leaks (see bugbear rule B019) lint: add yacc and lex automatically generated files to flake8 ignore these are the files of the simbad.utils.CriteriaTranslator parser fix: add a __call__ definition to make BaseVOQuery behave as BaseQuery add query_criteria_fialds.json and move from os to pathlib docs: document simbad refactoring fix: propagate simbad changes to jwst module this commit also adds a patch to simbad's query_objects in the tests docs: propagate simbad changes into the general documentation docs: simbad cache works differently now simbad calls lru_cache from python core library, so no cache_location tests: add simbad_output_options to path_tests refactor: remove utilities for the former sim script queries feat: add bibcodelist to possible outputs test: complete coverage of simbad utils tests: improve coverage for the tests without remote access docs: update simbad's doc fix: typo in vizier link feat: add ROW_LIMIT as a settable property rename 'add_to_output' into 'add_output_columns' docs: edit version of deprecation feat: reduce API changes docs: edits on votable fields utils docs: add changelog Co-authored-by: Adam Ginsburg <[email protected]> fix: rename typed_id into user_specified_id feat: add get_query_payload for the methods using TAP fix: wildcards in query_objects This was not tested remotely. And for now, this is extremely slow. Thus, the remote test for the wildcards in 'query_objects' is skipped except if SKIP_SLOW is set to False. On the other hand, when there is no wildcard in 'query_objects' there is a way faster method (join the small table on the left). So this PR also implements this. To use this faster method, the 'construct_query' had to become a bit general and now accepts a 'from_table' argument that defaults to 'basic'. docs: edit docstring and changelog from review Co-authored-by: Brigitta Sipőcz <[email protected]> tests: new measurement for sirius rotation refactor: remove Column and Join from SimbadClass DOC: minor changelog rephrase and reformat test different exceptions restore exceptions use timeout superclass
astropy · Jun 21, 2024 · 10885b2 · 10885b2
1 parent 25e6521
commit 10885b2
Show file tree

Hide file tree

Showing 86 changed files with 6,283 additions and 4,221 deletions.
diff --git a/.github/workflows/ci_crontests.yml b/.github/workflows/ci_crontests.yml
@@ -6,8 +6,8 @@ on:
     tags:
     - '*'
   schedule:
-    # run every Friday at 23:00 UTC
-    - cron: '0 23 * * 5'
+    # run every Friday at 22:00 UTC
+    - cron: '0 22 * * 5'
   workflow_dispatch:
 
 permissions:
@@ -22,24 +22,10 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - name: py3.11 all dev deps online
+          - name: py3.12 pre-release all deps
             os: ubuntu-latest
-            python: '3.11'
-            toxenv: py311-test-alldeps-devdeps-online
-            toxargs: -v
-            toxposargs: -v --durations=50
-
-          - name: Windows py3.9 all deps online
-            os: windows-latest
-            python: '3.9'
-            toxenv: py39-test-alldeps-online
-            toxargs: -v
-            toxposargs: -v --durations=50
-
-          - name: py3.11 pre-release all deps
-            os: ubuntu-latest
-            python: '3.11'
-            toxenv: py311-test-alldeps-predeps
+            python: '3.12'
+            toxenv: py312-test-alldeps-predeps
             toxargs: -v
             toxposargs: -v
 

diff --git a/.github/workflows/ci_online_crontests.yml b/.github/workflows/ci_online_crontests.yml
@@ -0,0 +1,51 @@
+name: CI-online-crontests
+
+on:
+  push:
+    # Run this job on release tags, but not on pushes to the main branch
+    tags:
+    - '*'
+  schedule:
+    # run every Friday at 23:00 UTC
+    - cron: '0 23 * * 5'
+  workflow_dispatch:
+
+permissions:
+  contents: read
+
+jobs:
+  tests:
+    name: ${{ matrix.name }}
+    runs-on: ${{ matrix.os }}
+    if: github.repository == 'astropy/astroquery'
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - name: py3.12 all dev deps online
+            os: ubuntu-latest
+            python: '3.12'
+            toxenv: py312-test-alldeps-devdeps-online
+            toxargs: -v
+            toxposargs: -v --durations=50
+
+          - name: Windows py3.9 all deps online
+            os: windows-latest
+            python: '3.9'
+            toxenv: py39-test-alldeps-online
+            toxargs: -v
+            toxposargs: -v --durations=50
+
+    steps:
+    - name: Checkout code
+      uses: actions/checkout@v4
+      with:
+        fetch-depth: 0
+    - name: Set up Python
+      uses: actions/setup-python@v5
+      with:
+        python-version: ${{ matrix.python }}
+    - name: Install Python dependencies
+      run: python -m pip install --upgrade tox
+    - name: Run tests
+      run: tox ${{ matrix.toxargs }} -e ${{ matrix.toxenv }} -- ${{ matrix.toxposargs }}
diff --git a/.mailmap b/.mailmap
@@ -3,6 +3,9 @@ Adam Ginsburg <[email protected]> <[email protected]>
 Adam Ginsburg <[email protected]> <[email protected]>
 Adrian Damian <[email protected]> <[email protected]>
 Andrew O'Brien <[email protected]> <[email protected]>
+Angel Ruiz <[email protected]>
+Antonio Ortega <[email protected]>
+Ari Pollak <[email protected]> <[email protected]>
 Austen Groener <[email protected]> <[email protected]>
 Austen Groener <[email protected]> <[email protected]>
 Ayush Yadav <[email protected]>
@@ -16,19 +19,23 @@ Clara Brasseur <[email protected]>
 David Collom  <[email protected]> <[email protected]>
 David Collom  <[email protected]> <[email protected]>
 David Collom  <[email protected]> <[email protected]>
+Dino Bektesevic <[email protected]>
 E. Madison Bray <[email protected]>
 E. Madison Bray <[email protected]> <[email protected]>
 Edward Gomez <[email protected]>
 Elena Colomo <[email protected]>
 Eric Koch <[email protected]>
 Erwan Pannier <[email protected]>
 Fran Raga <[email protected]> <[email protected]>
-Fred Moolekamp <[email protected]>Magnus Persson <[email protected]> <[email protected]>
+Fred Moolekamp <[email protected]>
+Hadrien Devillepoix <[email protected]>
 Hans Moritz Guenter <[email protected]>
 Henrik Norman <[email protected]> <[email protected]>
 Henrik Norman <[email protected]> <[email protected]>
+Henrik Norman <[email protected]> <[email protected]>
 Jaladh Singhal <[email protected]>
 James Dempsey <[email protected]> <[email protected]>
+James Guillochon <[email protected]>
 Javier Ballester <[email protected]>
 Javier Duran <[email protected]>
 Javier Duran <[email protected]> <[email protected]>
@@ -43,33 +50,49 @@ Javier Espinosa <[email protected]> <[email protected]
 Javier Espinosa <[email protected]> <[email protected]>
 Javier Espinosa <[email protected]> <[email protected]>
 Javier Espinosa <[email protected]> <[email protected]>
+Javier Espinosa <[email protected]> <[email protected]>
 Jennifer Medina <[email protected]>
 Jesus Juan Salgado <[email protected]>
+Jon Juaristi Campillo <[email protected]>
 Jonathan Gagne <[email protected]>
 Jordan Mirocha <[email protected]> <[email protected]>
+Jorge Fernandez Hernandez <[email protected]>
 Juan Carlos Segovia <[email protected]>
+Juanjo Bazán <[email protected]>
+Julien Milli <[email protected]>
 Julien Woillez <[email protected]> <[email protected]>
 Julien Woillez <[email protected]> <[email protected]>
+Kathleen Kiker <[email protected]> <[email protected]>
 Kelvin Lee <[email protected]>
+Kyle Willett <[email protected]>
 Larry Bradley <[email protected]>
 Loïc Séguin-C <[email protected]> <[email protected]>
 Luis Valero Martín <[email protected]>
 Madhura Parikh <[email protected]>
 Magnus Persson <[email protected]>
 Magnus Persson <[email protected]> <[email protected]>
+Manon Marchand <[email protected]>
 Maria H. Sarmiento <[email protected]>
 Matthew Craig <[email protected]>
 Matthieu Baumann <[email protected]> <[email protected]>
 Michael Mommert <[email protected]> <[email protected]>
+Michael Mommert <[email protected]> <[email protected]>
+Michael St. Clair <[email protected]>
+Michael St. Clair <[email protected]> <[email protected]>
 Michele Costa <[email protected]>
 Miguel de Val-Borro <[email protected]> <[email protected]>
 Natalie Korzh <[email protected]> <[email protected]>
+Naveen Srinivasan <[email protected]>
 Nicholas Earl <[email protected]>
 Oliver Oberdorf <[email protected]>
 Oliver Oberdorf <[email protected]> <[email protected]>
 Pey Lian Lim <[email protected]> <[email protected]>
+Prajwel Joseph <[email protected]>
 Raul Gutierrez <[email protected]> <Raul [email protected]>
 Raul Gutierrez <[email protected]> <[email protected]>
+Rounak Agarwal <[email protected]>
+Sam Lee <[email protected]>
+Sashank Mishra <[email protected]>
 Simon Conseil <[email protected]> <[email protected]>
 Simon Conseil <[email protected]> <[email protected]>
 Simon Liedtke <[email protected]>
@@ -78,5 +101,6 @@ Syed Gilani <[email protected]> <[email protected]>
 Syed Gilani <[email protected]>
 Tinuade Adeleke <[email protected]>
 Tim Galvin <[email protected]>
+Tomas Alonso Albi <[email protected]>
 Volodymyr Savchenko <[email protected]> <[email protected]>
 Volodymyr Savchenko <[email protected]> <[email protected]>
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -8,6 +8,13 @@ New Tools and Services
 Service fixes and enhancements
 ------------------------------
 
+alma
+^^^^
+
+- Added method to return quantities instead of values and regions footprint in alma [#2855]
+
+- Added support for frequency_resolution in KHz [#3035]
+
 mpc
 ^^^
 
@@ -18,6 +25,12 @@ linelists.cdms
 
 - Fix result parsing incompatibility with astropy 6.1 on Windows systems. [#3008]
 
+ogle
+^^^^
+
+- Change URL to https and thus making the module functional again. [#3048]
+
+
 splatalogue
 ^^^^^^^^^^^
 
@@ -29,13 +42,68 @@ vizier
 - Change the type of raised error when the catalog is not found in ``Vizier.get_catalog_metadata``
   from ``IndexError`` to ``EmptyResponseError`` [#2980]
 
+sdss
+^^^^
+
+- Support new SDSS-V DR18 access URLs. [#3017]
+
+simbad
+^^^^^^
+
+- The ``ROW_LIMIT`` value to have the maximum number of rows is now -1.
+  Use ``ROW_LIMIT = 0`` to retrieve the output's meta-data. [#2954]
+
+- ``ROW_LIMIT`` can now be set at instantiation
+  (e.g.: ``simbad = Simbad(ROW_LIMIT=10))``). [#2954]
+
+- ``list_votable_fields`` now return an astropy Table with added fields
+  information instead of a list of strings. [#2954]
+
+- ``list_votable_fields`` is now queried directly from SIMBAD instead of reading
+  a file in astroquery. This prevents it from being outdated. [#2954]
+
+- ``get_votable_fields`` now prints the table name and column name instead of
+  just the column name. [#2954]
+
+- The ``verbose`` and ``cache`` kwargs have been deprecated from all methods
+  as they have no effect with with the new query interface. [#2954]
+
+- ``get_adql`` is deprecated and replaced by ``get_query_payload`` in
+  ``list_columns`` and ``list_table``.
+  The payload output contains the ADQL under the ``QUERY`` key. [#2954]
+
+- all query methods except ``query_tap`` and ``query_criteria`` now accept a
+  ``criteria`` argument to restrict the results with custom criteria. [#2954]
+
+- ``query_objects`` outputs now have an additional column ``user_specified_id``
+  containing the objects' name as specified by the user.
+  The ``votable_field`` option ``typed_id`` is removed. [#2954]
+
+- The ``equinox`` and ``epoch`` kwargs are deprecated in ``query_region``,
+  use astropy.coordinates.SkyCoord directly instead. [#2954]
+
+- ``query_bibcode`` has a new option ``abstract`` that allows to also
+  retrieve the article's abstract. [#2954]
+
+- ``query_bibcode`` output is now in an astropy Table with distinct columns
+  instead of a single one in which all the information was a string. [#2954]
+
+- ``query_criteria`` is now deprecated and should be replaced by either custom
+  TAP queries or by the ``criteria`` argument added in the other query methods.
+  A helper method was added ``astroquery.simbad.utils.CriteriaTranslator`` to
+  translate between the sim-script syntax and the TAP/ADQL syntax. [#2954]
 
 skyview
 ^^^^^^^
 
 - Overlay arguments ``lut``, ``grid``, and ``gridlabel`` are removed, as they
   only apply to output types not returned by Astroquery [#2979]
 
+vsa
+^^^
+
+- Updating base URL to fix 404 responses. [#3033]
+
 
 Infrastructure, Utility and Other Changes and Additions
 -------------------------------------------------------
@@ -73,6 +141,16 @@ jplhorizons
 
 - Add missing column definitions, especially for ``refraction=True`` and ``extra_precision=True``. [#2986]
 
+mast
+^^^^
+
+- Fix bug in which the ``local_path`` parameter for the ``mast.observations.download_file`` method does not accept a directory. [#3016]
+
+- Optimize remote test suite to improve performance and reduce execution time. [#3036]
+
+- Add ``verbose`` parameter to modulate output in ``mast.observations.download_products`` method. [#3031]
+
+
 
 0.4.7 (2024-03-08)
 ==================

diff --git a/LICENSE.rst b/LICENSE.rst
@@ -1,4 +1,4 @@
-Copyright (c) 2011-2023 Astroquery Developers
+Copyright (c) 2011-2024 Astroquery Developers
 All rights reserved.
 
 Redistribution and use in source and binary forms, with or without modification,

diff --git a/README.rst b/README.rst
@@ -35,9 +35,10 @@ website <https://simbad.cds.unistra.fr/simbad/>`_, use the ``simbad`` sub-packag
     >>> from astroquery.simbad import Simbad
     >>> theta1c = Simbad.query_object('tet01 Ori C')
     >>> theta1c.pprint()
-       MAIN_ID          RA           DEC      ... COO_QUAL COO_WAVELENGTH     COO_BIBCODE
-    ------------- ------------- ------------- ... -------- -------------- -------------------
-    * tet01 Ori C 05 35 16.4637 -05 23 22.848 ...        A              O 2007A&A...474..653V
+       main_id          ra           dec      ... coo_wavelength     coo_bibcode       matched_id 
+                       deg           deg      ...                                                 
+    ------------- ------------- ------------- ... -------------- ------------------- -------------
+    * tet01 Ori C 83.8186095697 -5.3897005033 ...              O 2020yCat.1350....0G * tet01 Ori C
 
 Installation and Requirements
 -----------------------------

diff --git a/astroquery/alma/__init__.py b/astroquery/alma/__init__.py
@@ -38,8 +38,8 @@ class Conf(_config.ConfigNamespace):
 
 conf = Conf()
 
-from .core import Alma, AlmaClass, ALMA_BANDS
+from .core import Alma, AlmaClass, ALMA_BANDS, get_enhanced_table
 
 __all__ = ['Alma', 'AlmaClass',
-           'Conf', 'conf', 'ALMA_BANDS'
+           'Conf', 'conf', 'ALMA_BANDS', 'get_enhanced_table'
            ]