Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimport *Search from root __init__.py #498

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Reimport *Search from root __init__.py #498

merged 1 commit into from
Nov 8, 2024

Conversation

hombit
Copy link
Contributor

@hombit hombit commented Nov 8, 2024

It allows to do from lsdb import ConeSearch

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.67%. Comparing base (6129472) to head (95ff43c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #498   +/-   ##
=======================================
  Coverage   97.67%   97.67%           
=======================================
  Files          39       39           
  Lines        1550     1551    +1     
=======================================
+ Hits         1514     1515    +1     
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 8, 2024

Before [6129472] After [b024e54] Ratio Benchmark (Parameter)
100±1ms 103±1ms 1.02 benchmarks.time_kdtree_crossmatch
30.1±0.8ms 30.6±0.7ms 1.02 benchmarks.time_polygon_search
2.14±0.03s 2.16±0.01s 1.01 benchmarks.time_create_midsize_catalog
14.3±0.1s 14.4±0.03s 1 benchmarks.time_create_large_catalog
16.6±0.4ms 15.6±0.2ms 0.94 benchmarks.time_box_filter_on_partition

Click here to view all benchmarks.

@hombit hombit merged commit cad5981 into main Nov 8, 2024
11 checks passed
@hombit hombit deleted the reimport_search branch November 8, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants