Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some grammar and clarity updates #482

Merged
merged 7 commits into from
Nov 6, 2024
Merged

Some grammar and clarity updates #482

merged 7 commits into from
Nov 6, 2024

Conversation

OliviaLynn
Copy link
Member

@OliviaLynn OliviaLynn commented Oct 31, 2024

Misc notes:

  • Replacing performance testing plot image with a typo in the title
  • I'm ambivalent to the actual case of the tutorial titles, would just prefer consistency (either all title case or all only-first-word-capitalized)

Copy link

github-actions bot commented Oct 31, 2024

Before [62cefb8] After [5826ac3] Ratio Benchmark (Parameter)
15.3±0.2ms 15.7±0.2ms 1.02 benchmarks.time_box_filter_on_partition
98.4±1ms 98.5±1ms 1 benchmarks.time_kdtree_crossmatch
29.3±0.4ms 29.2±0.4ms 1 benchmarks.time_polygon_search
14.5±0.02s 14.4±0.02s 0.99 benchmarks.time_create_large_catalog
2.14±0.01s 2.12±0.01s 0.99 benchmarks.time_create_midsize_catalog

Click here to view all benchmarks.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.67%. Comparing base (62cefb8) to head (dfcd209).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #482   +/-   ##
=======================================
  Coverage   97.67%   97.67%           
=======================================
  Files          39       39           
  Lines        1550     1550           
=======================================
  Hits         1514     1514           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@OliviaLynn OliviaLynn changed the title (In Progress) Some small grammar nits Some grammar and clarity updates Nov 5, 2024
@OliviaLynn OliviaLynn marked this pull request as ready for review November 5, 2024 04:48
Copy link
Contributor

@delucchi-cmu delucchi-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@OliviaLynn OliviaLynn merged commit 5015b9b into main Nov 6, 2024
11 checks passed
@OliviaLynn OliviaLynn deleted the u/olynn/docs branch November 6, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants