Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catalog validation tutorial #480

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Closes #392.

Partially resolves #386 (documents the Catalog.schema attribute).

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

Before [b7f8127] <v0.4.1> After [19962c0] Ratio Benchmark (Parameter)
31.9±0.5ms 32.2±0.4ms 1.01 benchmarks.time_polygon_search
17.4±0.2ms 17.4±0.6ms 1 benchmarks.time_box_filter_on_partition
14.5±0.03s 14.5±0s 1 benchmarks.time_create_large_catalog
106±1ms 106±0.8ms 1 benchmarks.time_kdtree_crossmatch
2.15±0.01s 2.14±0.01s 0.99 benchmarks.time_create_midsize_catalog

Click here to view all benchmarks.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.67%. Comparing base (b7f8127) to head (801a714).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #480   +/-   ##
=======================================
  Coverage   97.67%   97.67%           
=======================================
  Files          39       39           
  Lines        1546     1546           
=======================================
  Hits         1510     1510           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu
Copy link
Contributor Author

@delucchi-cmu delucchi-cmu merged commit 5fbe2e2 into main Oct 31, 2024
11 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/392/validation_tutorial branch October 31, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: add a catalog validation tutorial Docs: explain Dask concepts and Catalog representation better
2 participants