-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-factor to simplify hats loading #461
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #461 +/- ##
==========================================
- Coverage 97.71% 97.65% -0.06%
==========================================
Files 44 39 -5
Lines 1619 1537 -82
==========================================
- Hits 1582 1501 -81
+ Misses 37 36 -1 ☔ View full report in Codecov by Sentry. |
Click here to view all benchmarks. |
3 tasks
camposandro
reviewed
Oct 28, 2024
camposandro
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complements (and requires) astronomy-commons/hats#394
Closes #460.
Puts all the file reading on loading a catalog into a single module. This reduces the complexity for reading the code, reduces code duplication, and also reduces the number of times we need to read the
properties
file, and perform file systemstat
calls to determine if files exist. This should speed up catalog loading on remote file systems where there is a latency associated with each file read.Enough of the code has changed, that we no longer need the additional (and mostly unused) argument for catalog type, in order to appease mypy type checking.