Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set _hipscat_index as pandas index, where possible. #415

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Closes #67

If the field _hipscat_index is present and NOT the index, set the pandas index in both the meta and incoming dataframes.

Copy link

github-actions bot commented Sep 16, 2024

Before [cb30209] After [9f8c913] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.time_box_filter_on_partition
failed 93.5±2ms n/a benchmarks.time_kdtree_crossmatch
25.9±0.3ms 27.3±0.7ms 1.05 benchmarks.time_polygon_search
1.72±0.01s 1.75±0.01s 1.02 benchmarks.time_create_midsize_catalog
11.5±0s 11.6±0.07s 1.01 benchmarks.time_create_large_catalog

Click here to view all benchmarks.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.87%. Comparing base (cb30209) to head (e62f365).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #415   +/-   ##
=======================================
  Coverage   97.86%   97.87%           
=======================================
  Files          44       44           
  Lines        1547     1553    +6     
=======================================
+ Hits         1514     1520    +6     
  Misses         33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu merged commit c478401 into main Sep 16, 2024
14 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/67/pandas_index branch September 16, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling _hipscat_index column if it is not a pandas index
2 participants