Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace FilePointer with universal pathlib #413

Merged
merged 10 commits into from
Sep 16, 2024
Merged

Conversation

delucchi-cmu
Copy link
Contributor

See astronomy-commons/hipscat#336

Solution Description

Use fsspec's project, universal-pathlib as a path provider. In this way, everywhere we currently pass in a FilePointer we can use a Path instead, and when we need to create remote connections, use UPath.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (90e0e72) to head (025da5d).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #413   +/-   ##
=======================================
  Coverage   97.86%   97.86%           
=======================================
  Files          44       44           
  Lines        1545     1547    +2     
=======================================
+ Hits         1512     1514    +2     
  Misses         33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 12, 2024

Before [a94b85b] After [7620281] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.time_box_filter_on_partition
failed 11.8±0.07s n/a benchmarks.time_create_large_catalog
failed 1.75±0.02s n/a benchmarks.time_create_midsize_catalog
failed 90.9±0.6ms n/a benchmarks.time_kdtree_crossmatch
failed 26.7±0.7ms n/a benchmarks.time_polygon_search

Click here to view all benchmarks.

@delucchi-cmu
Copy link
Contributor Author

Documentation issue will require astronomy-commons/hipscat-import#387, but I'd like to send for review for general comments.

Copy link
Contributor

@smcguire-cmu smcguire-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soo nice to be getting rid of storage options from everywhere

src/lsdb/catalog/dataset/healpix_dataset.py Outdated Show resolved Hide resolved
@delucchi-cmu delucchi-cmu merged commit cb30209 into main Sep 16, 2024
12 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/upath branch September 16, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants