Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap nested_dask dropna function #410

Merged
merged 6 commits into from
Sep 12, 2024
Merged

Wrap nested_dask dropna function #410

merged 6 commits into from
Sep 12, 2024

Conversation

smcguire-cmu
Copy link
Contributor

Part of #372, wraps the dropna function from nested_dask as a catalog method

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (57dca96) to head (90e0e72).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
- Coverage   98.00%   97.86%   -0.15%     
==========================================
  Files          44       44              
  Lines        1504     1545      +41     
==========================================
+ Hits         1474     1512      +38     
- Misses         30       33       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 26, 2024

Before [e3600fd] After [2079e3f] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.time_box_filter_on_partition
26.2±0.3ms 26.5±0.4ms 1.01 benchmarks.time_polygon_search
1.54±0.02s 1.54±0.02s 1.00 benchmarks.time_create_midsize_catalog
90.9±1ms 90.6±1ms 1.00 benchmarks.time_kdtree_crossmatch
10.2±0.08s 10.2±0.07s 0.99 benchmarks.time_create_large_catalog

Click here to view all benchmarks.

Copy link
Contributor

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks Sean. Just recommending you add an additional test.

tests/lsdb/catalog/test_nested.py Show resolved Hide resolved
Copy link
Contributor

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sean, looks good!

@smcguire-cmu smcguire-cmu merged commit a94b85b into main Sep 12, 2024
11 of 12 checks passed
@smcguire-cmu smcguire-cmu deleted the sean/dropna branch September 12, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants