Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to query params on http filesystem #355

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Support to query params on http filesystem #355

merged 2 commits into from
Jun 14, 2024

Conversation

Schwarzam
Copy link
Contributor

This PR works on top of hipscat #291 PR.

It creates the url params dict to be transformed to url params in hipscat.

Copy link

github-actions bot commented Jun 11, 2024

Before [73948db] After [4c55634] Ratio Benchmark (Parameter)
3.25±0.02s 3.23±0.03s 0.99 benchmarks.time_create_large_catalog
495±7ms 488±3ms 0.99 benchmarks.time_create_midsize_catalog
54.5±1ms 52.9±0.8ms 0.97 benchmarks.time_kdtree_crossmatch
17.2±0.3ms 16.7±0.4ms 0.97 benchmarks.time_polygon_search
7.59±0.3ms 7.18±0.09ms 0.95 benchmarks.time_box_filter_on_partition

Click here to view all benchmarks.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.31%. Comparing base (73948db) to head (fdcf60d).
Report is 91 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
+ Coverage   98.30%   98.31%   +0.01%     
==========================================
  Files          43       43              
  Lines        1418     1427       +9     
==========================================
+ Hits         1394     1403       +9     
  Misses         24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@delucchi-cmu delucchi-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion - otherwise looks good to me! Feel free to merge the change after addressing the small thing.

src/lsdb/loaders/hipscat/abstract_catalog_loader.py Outdated Show resolved Hide resolved
@Schwarzam Schwarzam merged commit c56b6a4 into main Jun 14, 2024
12 checks passed
@Schwarzam Schwarzam deleted the parquet-server branch June 14, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants