-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to query params on http filesystem #355
Conversation
Click here to view all benchmarks. |
1304b42
to
73948db
Compare
7ec0afa
to
e66cad6
Compare
e66cad6
to
73948db
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
==========================================
+ Coverage 98.30% 98.31% +0.01%
==========================================
Files 43 43
Lines 1418 1427 +9
==========================================
+ Hits 1394 1403 +9
Misses 24 24 ☔ View full report in Codecov by Sentry. |
59d0260
to
f8a8b7d
Compare
f8a8b7d
to
970bf94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestion - otherwise looks good to me! Feel free to merge the change after addressing the small thing.
Co-authored-by: Melissa DeLucchi <[email protected]>
This PR works on top of
hipscat
#291 PR.It creates the url params dict to be transformed to url params in hipscat.