Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable anonymous S3 access by default #466

Merged
merged 5 commits into from
Mar 5, 2025
Merged

Conversation

camposandro
Copy link
Contributor

Support anonymous S3 connections without requiring the user to provide a UPath(..., anon=True). This change includes a test for read_hats which verifies that we only initialize the UPath once. Closes #462.

  • My PR includes a link to the issue that I am addressing

@camposandro camposandro requested a review from delucchi-cmu March 4, 2025 16:07
@camposandro camposandro self-assigned this Mar 4, 2025
Copy link

github-actions bot commented Mar 4, 2025

Before [435ef8d] <v0.4.7> After [9e0248a] Ratio Benchmark (Parameter)
72.3±0.3ms 73.5±0.4ms 1.02 benchmarks.MetadataSuite.time_load_partition_info_order7
105±1ms 106±0.5ms 1.02 benchmarks.time_test_alignment_even_sky
72.3±0.2ms 72.9±0.3ms 1.01 benchmarks.MetadataSuite.time_load_partition_join_info
1.03±0.01ms 1.04±0.03ms 1.01 benchmarks.time_test_cone_filter_multiple_order
12.4±0.4ms 12.4±0.3ms 1 benchmarks.Suite.time_inner_pixel_alignment
353±2ms 351±2ms 0.99 benchmarks.Suite.time_outer_pixel_alignment
18.9±0.06ms 18.6±0.1ms 0.98 benchmarks.MetadataSuite.time_load_partition_info_order6
39.9±0.7ms 39.0±0.5ms 0.98 benchmarks.Suite.time_pixel_tree_creation

Click here to view all benchmarks.

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.21%. Comparing base (757426f) to head (24852e0).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #466      +/-   ##
==========================================
+ Coverage   93.19%   93.21%   +0.01%     
==========================================
  Files          47       47              
  Lines        2028     2033       +5     
==========================================
+ Hits         1890     1895       +5     
  Misses        138      138              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support anonymous S3 connections without requiring the user to provide a UPath
2 participants