Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pass additional kwargs to file open. #465

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Ran into a problem with requests to HTTP and requiring a csv header row, where {header:infer} is a valid answer for pandas csv reader, but really confuses HTTP.

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.19%. Comparing base (9fcd5a5) to head (230ee85).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #465   +/-   ##
=======================================
  Coverage   93.19%   93.19%           
=======================================
  Files          47       47           
  Lines        2028     2028           
=======================================
  Hits         1890     1890           
  Misses        138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 3, 2025

Before [9fcd5a5] After [af23135] Ratio Benchmark (Parameter)
1.30±0.2ms 1.03±0.02ms ~0.79 benchmarks.time_test_cone_filter_multiple_order
12.5±0.3ms 13.2±0.8ms 1.06 benchmarks.Suite.time_inner_pixel_alignment
71.9±0.4ms 72.5±0.3ms 1.01 benchmarks.MetadataSuite.time_load_partition_info_order7
18.3±0.09ms 18.3±0.06ms 1.00 benchmarks.MetadataSuite.time_load_partition_info_order6
72.1±0.9ms 72.3±0.4ms 1.00 benchmarks.MetadataSuite.time_load_partition_join_info
38.9±0.7ms 38.8±0.5ms 1.00 benchmarks.Suite.time_pixel_tree_creation
354±4ms 347±3ms 0.98 benchmarks.Suite.time_outer_pixel_alignment
106±0.4ms 104±2ms 0.98 benchmarks.time_test_alignment_even_sky

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu merged commit 435ef8d into main Mar 3, 2025
12 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/kwargs branch March 3, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants