Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be safer around none values in metadata statistics. #460

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

delucchi-cmu
Copy link
Contributor

If metadata files are lacking statistics, or contain only none values within in a partition, we should confirm that we're not making none comparisons.

Note that we are not able to rely on numpy's nanmin kind of methods, as these are None, and will not have the same type.

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.19%. Comparing base (af79a37) to head (8ca5744).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
+ Coverage   93.14%   93.19%   +0.04%     
==========================================
  Files          47       47              
  Lines        2014     2028      +14     
==========================================
+ Hits         1876     1890      +14     
  Misses        138      138              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Before [af79a37] After [37154cf] Ratio Benchmark (Parameter)
1.03±0.02ms 1.03±0.02ms 1.01 benchmarks.time_test_cone_filter_multiple_order
73.4±0.4ms 73.1±0.3ms 1 benchmarks.MetadataSuite.time_load_partition_info_order7
39.6±0.3ms 39.5±0.6ms 1 benchmarks.Suite.time_pixel_tree_creation
108±0.4ms 107±0.5ms 1 benchmarks.time_test_alignment_even_sky
73.4±0.4ms 72.3±0.2ms 0.99 benchmarks.MetadataSuite.time_load_partition_join_info
359±3ms 355±2ms 0.99 benchmarks.Suite.time_outer_pixel_alignment
18.8±0.1ms 18.4±0.2ms 0.98 benchmarks.MetadataSuite.time_load_partition_info_order6
13.0±0.2ms 12.3±0.7ms 0.95 benchmarks.Suite.time_inner_pixel_alignment

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu merged commit 757426f into main Feb 28, 2025
12 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/none_stats branch February 28, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants