Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use numba jit compilation instead of precompilation #395

Merged
merged 8 commits into from
Oct 25, 2024

Conversation

smcguire-cmu
Copy link
Contributor

Removes type from njit decorators to compile just in time

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.87%. Comparing base (4ef9952) to head (5488203).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
- Coverage   92.87%   92.87%   -0.01%     
==========================================
  Files          49       49              
  Lines        2134     2132       -2     
==========================================
- Hits         1982     1980       -2     
  Misses        152      152              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 25, 2024

Before [4ef9952] After [b74226f] Ratio Benchmark (Parameter)
13.0±0.3ms 13.7±0.9ms 1.06 benchmarks.Suite.time_inner_pixel_alignment
22.2±0.1ms 23.4±0.04ms 1.05 benchmarks.MetadataSuite.time_load_partition_info_order6
987±5μs 1.02±0.02ms 1.04 benchmarks.time_test_cone_filter_multiple_order
94.0±0.8ms 94.8±0.6ms 1.01 benchmarks.MetadataSuite.time_load_partition_info_order7
93.7±0.6ms 95.0±0.5ms 1.01 benchmarks.MetadataSuite.time_load_partition_join_info
124±0.5ms 125±0.4ms 1.01 benchmarks.time_test_alignment_even_sky
381±3ms 381±3ms 1 benchmarks.Suite.time_outer_pixel_alignment
111±2ms 110±1ms 1 benchmarks.Suite.time_paths_creation
49.9±0.8ms 45.9±0.4ms 0.92 benchmarks.Suite.time_pixel_tree_creation

Click here to view all benchmarks.

@smcguire-cmu smcguire-cmu enabled auto-merge (squash) October 25, 2024 17:36
@smcguire-cmu smcguire-cmu merged commit f2704b8 into main Oct 25, 2024
10 checks passed
@smcguire-cmu smcguire-cmu deleted the sean/speedup-import branch October 25, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants