Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fishy file #390

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Remove fishy file #390

merged 1 commit into from
Oct 22, 2024

Conversation

delucchi-cmu
Copy link
Contributor

This file shouldn't be here. It was either missed in the HATS renaming, or mistakenly re-added in follow-up PRs.

Copy link

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@delucchi-cmu delucchi-cmu merged commit cd18fe3 into main Oct 22, 2024
9 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/fishy branch October 22, 2024 18:39
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.98%. Comparing base (cfffa75) to head (079524a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #390   +/-   ##
=======================================
  Coverage   92.98%   92.98%           
=======================================
  Files          49       49           
  Lines        1996     1996           
=======================================
  Hits         1856     1856           
  Misses        140      140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Before [cfffa75] After [766ccc7] Ratio Benchmark (Parameter)
71.7±0.3ms 72.8±1ms 1.02 benchmarks.MetadataSuite.time_load_partition_info_order7
16.9±0.1ms 17.1±0.4ms 1.01 benchmarks.MetadataSuite.time_load_partition_info_order6
13.0±0.3ms 13.1±0.2ms 1.01 benchmarks.Suite.time_inner_pixel_alignment
374±2ms 376±3ms 1.01 benchmarks.Suite.time_outer_pixel_alignment
42.7±0.7ms 43.3±0.6ms 1.01 benchmarks.Suite.time_pixel_tree_creation
72.4±1ms 72.0±0.9ms 1 benchmarks.MetadataSuite.time_load_partition_join_info
89.3±3ms 89.6±3ms 1 benchmarks.Suite.time_paths_creation
120±0.8ms 120±0.5ms 1 benchmarks.time_test_alignment_even_sky
1.05±0.01ms 1.04±0ms 1 benchmarks.time_test_cone_filter_multiple_order

Click here to view all benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants