Prefer reading CSV and issue warning #203
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Close astronomy-commons/lsdb#107
After considering alternative storage strategies, there isn't a significant enough performance gain to warrant adding a new file. So this change make the partition info (and partition join info) reading prefer using the
partition_info.csv
file. We throw a warning to say that this operation is slow (which the user will notice when it's slow, but can get a hint that there's a faster way to proceed instead).See analysis with numpy binary files as example. https://github.com/lincc-frameworks/notebooks_lf/blob/main/sprints/2024/02_08/npy_stuff.ipynb
Code Quality