Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-discover all leaf files for dataset creation. #501

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

delucchi-cmu
Copy link
Contributor

There's some weird interaction between arrow, fsspec, and HTTP, whereby discovery of nested files doesn't behave well and the dataset appears empty, when calling parquet.dataset() with an HTTP directory.

This change recursively finds all files under the Norder* directories, discards more directories, and cleans up the URL string (e.g. Norder%3D0/... to Norder=0/...), so they match the relative paths contained in the _metadata file.

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.84%. Comparing base (98205be) to head (82c152c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
+ Coverage   94.82%   94.84%   +0.01%     
==========================================
  Files          28       28              
  Lines        1818     1823       +5     
==========================================
+ Hits         1724     1729       +5     
  Misses         94       94              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu requested a review from hombit March 4, 2025 11:34
Copy link
Contributor

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@delucchi-cmu delucchi-cmu merged commit f00cd7a into main Mar 4, 2025
10 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/discovery branch March 4, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants