Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested changes from science homework. #476

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

delucchi-cmu
Copy link
Contributor

See: astronomy-commons/lsdb#541

  • Give (only slightly) more friendly error message when some stages of the import task fail
  • Clarify that the "public catalogs" page is just tips for various catalogs
  • Provide link to data.lsdb.io
  • Fix doc links for import notebooks

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.11%. Comparing base (2e50284) to head (50f49a1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #476   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files          28       28           
  Lines        1802     1802           
=======================================
  Hits         1714     1714           
  Misses         88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gitosaurus gitosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@delucchi-cmu delucchi-cmu merged commit 48778ea into main Jan 22, 2025
10 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/lsdb/541 branch January 22, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants