Avoid overwriting valid catalogs.

[gitosaurus]

Strong refusal without options, since it's easier and safer to move the catalog out of the way.

Change Description

Before beginning a catalog import or generating a margin cache, check whether the output artifact already contains a valid catalog, and if so, stop by raising a ValueError.

Closes #459 .

• My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

• I have read the Contribution Guide and LINCC Frameworks Code of Conduct
• My code follows the code style of this project
• My code builds (or compiles) cleanly without any errors or warnings
• My code contains relevant comments and necessary documentation

Bug Fix Checklist

Tested this end-to-end on epyc, and verified it, and added unit tests to verify argument validation.

• My fix includes a new test that breaks as a result of the bug (if possible)
• My change includes a breaking change
  • My change includes backwards compatibility and deprecation warnings (if possible)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.59%. Comparing base (e401c6c) to head (0b3e702).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
+ Coverage   94.55%   94.59%   +0.04%     
==========================================
  Files          28       28              
  Lines        1615     1627      +12     
==========================================
+ Hits         1527     1539      +12     
  Misses         88       88              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[maxwest-uw]

Should this be using the strict option for is_valid_catalog ? naively it seems like the non-strict option only checks if there are valid partition and metadata files (which might cause problems in the cause where an import was paused/interrupted). Otherwise this looks good to me !

[gitosaurus]

Should this be using the strict option for is_valid_catalog ? naively it seems like the non-strict option only checks if there are valid partition and metadata files (which might cause problems in the cause where an import was paused/interrupted). Otherwise this looks good to me !

The main reason is performance: strict=False (the default) takes ~3ms to run, while strict=True takes ~25s. Moreover, strict=False will still correctly reject in-progress catalogs as invalid, in my testing.

[maxwest-uw]

oh if it's that slow than I think non strict is probably fine :)