Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RA, DEC must be double-precision, not single, for radec2pix #461

Closed
wants to merge 1 commit into from

Conversation

gitosaurus
Copy link
Contributor

Change Description

Ensure that RA and DEC are double-precision before calling radec2pix. When they are single-precision, that function fails with a TypeError.

Closes #458 . Verified during #460 .

  • My PR includes a link to the issue that I am addressing

Code Quality

  • I have read the Contribution Guide and LINCC Frameworks Code of Conduct
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

@gitosaurus gitosaurus linked an issue Dec 20, 2024 that may be closed by this pull request
3 tasks
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.55%. Comparing base (f99ef80) to head (15144c2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #461   +/-   ##
=======================================
  Coverage   94.55%   94.55%           
=======================================
  Files          28       28           
  Lines        1615     1615           
=======================================
  Hits         1527     1527           
  Misses         88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gitosaurus
Copy link
Contributor Author

While this fix unblocked the work in #460, it's not quite general enough. Following discussion, will close this in favor of a more abstract fix within the hats project.

@gitosaurus gitosaurus closed this Dec 23, 2024
@gitosaurus gitosaurus deleted the 458-typeerror-converting-ztf-lc-from-hats branch December 23, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError when converting ZTF Lightcurves from hipscat -> hats
1 participant