Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove margin fine filtering, and healpy dependency. #442

Merged
merged 6 commits into from
Nov 26, 2024
Merged

Conversation

delucchi-cmu
Copy link
Contributor

No description provided.

* Remove margin fine filtering.

* Use different methods for healpix manipulation.

* Optional dependency for older healpy fits files.

* Allow import of map types. (#437)

* Accomodate changes in cds-healpix.
Copy link

github-actions bot commented Nov 25, 2024

Before [d928c82] After [ebd667f] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.BinningSuite.time_read_histogram

Click here to view all benchmarks.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.57%. Comparing base (d928c82) to head (14f2c19).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
...hats_import/margin_cache/margin_cache_arguments.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
- Coverage   98.64%   98.57%   -0.07%     
==========================================
  Files          28       28              
  Lines        1620     1615       -5     
==========================================
- Hits         1598     1592       -6     
- Misses         22       23       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu merged commit e5b02fa into main Nov 26, 2024
8 of 11 checks passed
@delucchi-cmu delucchi-cmu deleted the margin branch December 10, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants