Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge development branch #417

Merged
merged 10 commits into from
Oct 22, 2024
Merged

Merge development branch #417

merged 10 commits into from
Oct 22, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Merges the changes performed on development during the HATS renaming back to the main branch.

dependabot bot and others added 9 commits October 1, 2024 07:22
Bumps [dawidd6/action-download-artifact](https://github.com/dawidd6/action-download-artifact) from 3 to 6.
- [Release notes](https://github.com/dawidd6/action-download-artifact/releases)
- [Commits](dawidd6/action-download-artifact@v3...v6)

---
updated-dependencies:
- dependency-name: dawidd6/action-download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [pre-commit-ci/lite-action](https://github.com/pre-commit-ci/lite-action) from 1.0.2 to 1.0.3.
- [Release notes](https://github.com/pre-commit-ci/lite-action/releases)
- [Commits](pre-commit-ci/lite-action@v1.0.2...v1.0.3)

---
updated-dependencies:
- dependency-name: pre-commit-ci/lite-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
…ons/pre-commit-ci/lite-action-1.0.3

Bump pre-commit-ci/lite-action from 1.0.2 to 1.0.3
…ons/dawidd6/action-download-artifact-6

Bump dawidd6/action-download-artifact from 3 to 6
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.85%. Comparing base (bdee662) to head (677fe47).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
- Coverage   98.88%   98.85%   -0.03%     
==========================================
  Files          29       28       -1     
  Lines        1612     1576      -36     
==========================================
- Hits         1594     1558      -36     
  Misses         18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@camposandro camposandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Can we just make a small change and install from hats@main for the benchmarks?

From

"python -m pip install {wheel_file}"

to

"python -m pip install -r requirements.txt {wheel_file}"

Copy link

Before [bdee662] After [23a4617] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.BinningSuite.time_read_histogram

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu merged commit a3c72f3 into main Oct 22, 2024
16 of 17 checks passed
@delucchi-cmu delucchi-cmu deleted the development branch October 22, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants