Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loads of small cleanups #203

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Loads of small cleanups #203

merged 4 commits into from
Jan 19, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

  • creates a shared get_pixel_cache_directory, as we were duplicating logic in a few places (and there was a TODO)
  • use HealpixPixel where possible
  • remove all macauff references - the entire pipeline was moved to the macauff/lsdb_macauff repo a few weeks ago (LINK)
  • removed pylint disablement statements where there's no pylint warning
  • ran black and isort
  • fix a few docstrings (pydoclint now reports "No violations"!)

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c87019) 99.45% compared to head (d19f59e) 99.74%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
+ Coverage   99.45%   99.74%   +0.28%     
==========================================
  Files          29       24       -5     
  Lines        1466     1166     -300     
==========================================
- Hits         1458     1163     -295     
+ Misses          8        3       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu merged commit 862ea03 into main Jan 19, 2024
12 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/cleanup branch January 19, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants