Deprecate GCS sensors #1444
Merged
Deprecate GCS sensors #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
requested review from
phanikumv,
pankajastro,
pankajkoti,
sunank200,
utkarsharma2 and
vatsrahul1001
as code owners
15 tasks
|
Unrelated Mypy failures would be fixed by #1443 |
Lee-W
force-pushed
the
deprecate-gcs-sensors
branch
from
2a01252 to
add7c91
Compare
pankajkoti
reviewed
Jan 22, 2024
Lee-W
force-pushed
the
deprecate-gcs-sensors
branch
from
15761c7 to
8c25d9c
Compare
|
Lee-W
force-pushed
the
deprecate-gcs-sensors
branch
from
9008c98 to
bc0ac6a
Compare
pankajkoti
approved these changes
Jan 22, 2024
|
looks like we have some mypy failures that would need to be resolved. |
|
It seems to be an open issue of mypy. Will add type ignore to this one |
Lee-W
force-pushed
the
deprecate-gcs-sensors
branch
from
bc0ac6a to
de30854
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1444 +/- ##
==========================================
+ Coverage 98.39% 98.46% +0.06%
==========================================
Files 91 91
Lines 5175 5142 -33
==========================================
- Hits 5092 5063 -29
+ Misses 83 79 -4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
GCSObjectExistenceSensorAsync,GCSObjectsWithPrefixExistenceSensorAsync,GCSUploadSessionCompleteSensorAsync,GCSObjectUpdateSensorAsyncand proxy itto its Airflow OSS provider's counterpart