Deprecate WasbBlobSensorAsync #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate WasbBlobSensorAsync and proxy it to its Airflow OSS provider's counterpart related: #1412
|
Successful DAG runs showing poking before defferal and deferral working Deferring when file does not exists |
pankajkoti
requested review from
phanikumv,
pankajastro,
Lee-W,
sunank200,
utkarsharma2 and
vatsrahul1001
as code owners
4 tasks
|
Tests seem to be failing for unrelated reasons. Need to be looked into separately. However, I would appreciate reviews on this as we need to merge this one before I cut a branch for deprecating the WasbPrefixSensorAsync as both share the same modules and may cause conflicts and also its easier to identify and cleanup unneeded code/imports. |
vatsrahul1001
approved these changes
Jan 19, 2024
|
LGTM |
|
Thanks @vatsrahul1001 for the review. I am merging this for the reason mentioned in comment #1435 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate WasbBlobSensorAsync and proxy it to its Airflow OSS
provider's counterpart
related: #1412