Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(amazon/emr): remove unnecessary return in EmrContainerOperatorAsync and Redshift Cluster operators #1430

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

@Lee-W Lee-W changed the title refactor(amazon/emr): remove unnecessay return in EmrContainerOperatorAsync refactor(amazon/emr): remove unnecessary return in EmrContainerOperatorAsync Jan 18, 2024
@Lee-W Lee-W force-pushed the remove-unnecessary-return branch from f76cb43 to 82ec119 Compare January 18, 2024 09:24
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b697ecc) 98.40% compared to head (e18fb3b) 98.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1430   +/-   ##
=======================================
  Coverage   98.40%   98.40%           
=======================================
  Files          91       91           
  Lines        5199     5199           
=======================================
  Hits         5116     5116           
  Misses         83       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also update the PR title to make it generic as we have changes in multiple operators now :)

@Lee-W Lee-W changed the title refactor(amazon/emr): remove unnecessary return in EmrContainerOperatorAsync refactor(amazon/emr): remove unnecessary return in EmrContainerOperatorAsync and Redshift Cluster operators Jan 18, 2024
@Lee-W Lee-W merged commit 0bb0a58 into main Jan 19, 2024
11 checks passed
@Lee-W Lee-W deleted the remove-unnecessary-return branch January 19, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants