Gracefully error when users set imcompatible RenderConfig.dbt_deps and operator_args install_deps
#1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
dosubot
bot
added
area:rendering
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1505 +/- ##
=======================================
Coverage 97.31% 97.31%
=======================================
Files 79 79
Lines 4616 4618 +2
=======================================
+ Hits 4492 4494 +2
Misses 124 124 ☔ View full report in Codecov by Sentry. |
pankajkoti
reviewed
Feb 4, 2025
tatiana
commented
Feb 6, 2025
Deploying astronomer-cosmos with
|
| Latest commit: |
7178870
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e3dcb20a.astronomer-cosmos.pages.dev |
| Branch Preview URL: | https://issue-1457.astronomer-cosmos.pages.dev |
pankajkoti
approved these changes
Feb 6, 2025
…and operator_args install_deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer is facing this error when
RenderConfig(dbt_deps=True)andoperator_args={"install_deps": False}:This issue does not happen if both of them are
False.Closes: #1458
Closes: #1457