-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Docs DAG in CI leveraging existing CI connections #1428
Conversation
✅ Deploy Preview for sunny-pastelito-5ecb04 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
c6c6a21
to
54b6d5f
Compare
Deploying astronomer-cosmos with Cloudflare Pages
|
Action run https://github.com/astronomer/astronomer-cosmos/actions/runs/12500718837/job/34877247783?pr=1428 before merging and rebasing PR #1422 here shows that we now are running the example DAG for docs upload test in our CI with this PR. |
54b6d5f
to
d44d5bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing this, @pankajkoti ! It seems the CI is failing for other reasons. Happy for this to be merged once we address the other issues in a separate PR - so the CI is green.
ce2a927
to
ec6484e
Compare
12f0a24
to
bdde29f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1428 +/- ##
==========================================
+ Coverage 96.52% 96.92% +0.39%
==========================================
Files 73 73
Lines 4320 4320
==========================================
+ Hits 4170 4187 +17
+ Misses 150 133 -17 ☔ View full report in Codecov by Sentry. |
thanks @tatiana . There were a couple of issues. One of them was resolved in PR #1432 . The other being that the DAG operators were leading to compilation errors as dbt deps were not installed, which led to failing command execution and hence no target directory was created from where we were trying to upload the files. We now are installing dbt deps in the DAG operators. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing all the issues, @pankajkoti !
1.8.1 (2024-12-30) -------------------- Bug Fixes * Fix rendering dbt tests with multiple parents by @tatiana in #1433 * Add ``kwargs`` param in DocsOperator method ``upload_to_cloud_storage`` by @pankajastro in #1422 Docs * Improve OpenLineage documentation by @tatiana in #1431 Others * Enable Docs DAG in CI leveraging existing CI connections by @pankajkoti in #1428 * Install providers with airflow by @pankajkoti in #1432 * Remove unused docs dependency by @pankajastro in #1414 * Pre-commit hook updates in #1424 --------- Co-authored-by: Tatiana Al-Chueyr <[email protected]> Co-authored-by: Pankaj Koti <[email protected]>
It seems that the dbt docs DAG in our example DAGs suite was silently failing to run because the specified connections in the DAG were not present in our CI environment. I am removing the connection checks, allowing the previously skipped tasks to execute even when the remote Airflow connections are unavailable. Additionally, I’ve updated the DAG to use our existing CI credentials and Airflow connections, as well as updated the bucket name to the ones I created in our object stores. This change will help catch issues like #1420 earlier. While fix #1422 has already addressed #1420, this PR will now validate that the fix is functioning as expected.
closes: #1420