Respect default value #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted default keyword argument
|
@burnpanck - can you rebase on the latest master and push to this branch again? I had to fix some issues with Travis in #18 - thanks! |
|
Ugh, coverage dropped, because there is now a deprecated |
|
Oh, and I see #13 also solves the same issue just without a deprecated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a default value is supplied using the keyword argument
default, it is silently ignored. Furthermore, standard traitlets take a default value using the keyword argumentdefault_value. The latter is now forwarded to traitlets, while the former is made a deprecated alias.