Fixes to Dilaton Axion metric #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calculated the inner radius by hand, as there is currently no good cache support for this value, so having a root solver here would be a considerable performance overhead. Also re-implemented the metric and removed the fastmath macros to give better stability and remove ambiguous UTF-8 characters.
We now also keep the theta (polar) velocity array and return it when interpolating the plunging region velocities. This is because, e.g. the EMDA metric in free-fall has a non-zero polar component, which needs to be taken account of.
For the EMDA, now testing against a value from a figure in Younsi et al, 2023. For the precisions, this I think is due to a change in Julia version.
|
This should likely also resolve #52 but need to check! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.