feat(auctioneer): add metrics #1953
Conversation
SuperFluffy
force-pushed
the
superfluffy/metrics
branch
from
91c1547 to
c1af0a3
Compare
| OPTIMISTIC_BLOCKS_RECEIVED, | ||
| AUCTIONS_CANCELLED, | ||
| AUCTIONS_SUBMITTED, | ||
| AUCTION_BIDS_PROCESSED, |
There was a problem hiding this comment.
I am not happy with this name - I want to have a gauge with 2 labels: bids admitted and bids dropped. "processed" seems confusing. Are there better names?
There was a problem hiding this comment.
lets make the bids received and dropped a histogram.
There was a problem hiding this comment.
See my other comment in #1953 (comment), copied here:
The distinction is important actually (received is processed + dropped), but I did change the nomenclature in 27af6c1 (now the histogram is just "auction_bids" with labels ["processed", "dropped"]).
SuperFluffy
force-pushed
the
superfluffy/metrics
branch
from
c1af0a3 to
b444e94
Compare
SuperFluffy
force-pushed
the
superfluffy/metrics
branch
from
b444e94 to
256bc8d
Compare
| @@ -272,6 +283,9 @@ impl Auctioneer { | |||
| "block_hash", | |||
| field::display(executed_block.sequencer_block_hash()), | |||
| ); | |||
|
|
|||
| self.metrics.increment_executed_blocks_received_counter(); | |||
There was a problem hiding this comment.
this can act as a proxy for the metric "number of auctions conducted" since an auction starts when the auctioneer receives an executed block.
| RegisteringBuilder, | ||
| }, | ||
| }; | ||
|
|
||
| pub struct Metrics {} | ||
| const AUCTION_BIDS_PROCESSED_LABEL: &str = "auction_bids_processed"; | ||
| const AUCTION_BIDS_PROCESSED_ADMITTED: &str = "admitted"; |
There was a problem hiding this comment.
i feel like received is a better word than admitted.
There was a problem hiding this comment.
The distinction is important actually (received is processed + dropped), but I did change the nomenclature in 27af6c1 (now the histogram is just "auction_bids" with labels ["processed", "dropped"]).
|
Some metrics to add and feedback:
|
| self.auction_winning_bid_histogram.record(val); | ||
| } | ||
|
|
||
| pub(crate) fn record_auction_winner_submission_error_latency(&self, val: impl IntoF64) { |
There was a problem hiding this comment.
we also might want the number of times submission has error'ed out. We could use this for an alert to indicate when auctioneer has a high submission error rate which is something actionable?
There was a problem hiding this comment.
Isn't that covered by the same histogram with the "error" label (see the method just below this one)?
There was a problem hiding this comment.
yes, the histogram metric will return a total count too. so that should cover it!
Summary
Extend Auctioneer by a first set of metrics.
Background
Astria services must be observable, metrics are low hanging fruit.
Changes
Testing
This needs to be observed on a telemetry platform.
Changelogs
Changelogs updated.
Metrics
Related Issues
closes #1915