Use a single lint task in CI #7540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have fast lints for different languages (Rust, Python, {json5,yaml,yml}, Markdown). Instead of arbitrarily splitting them and reporting e.g. prettier failures as Rust problems, we run them in a single job that's still <1min on a regular runner. This also reduces the test matrix by one job.
zanieb
reviewed
Sep 19, 2024
zanieb
approved these changes
Sep 19, 2024
|
I disabled the branch protection check for 'cargo fmt' |
|
I think you'll need to disable the cache |
|
The cache dir is set unconditionally at https://github.com/astral-sh/setup-uv/blob/ce0062aac78b2f340c6612e0e40b80a2fa668ced/src/setup-uv.ts#L48. We can't unset an env var (actions/runner#1126), but we should also in general make our test suite robust against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We initially had two jobs for fast lints, one for Python and one for Rust (rustfmt). We now have fast lints for more (Rust, Python, {json5,yaml,yml}, Markdown, Readme). Instead of arbitrarily splitting the new cases between Python or Rust and reporting e.g. Prettier failures as Rust problems, we run them in a single job that's still <1min on a regular runner. This also reduces our large test matrix by one job.
Note: Before merging, we need to change the required checks configuration in the settings.