add pip-compatible --group flag to uv pip install
#11686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gankra
commented
Feb 21, 2025
Comment on lines
+68
to
+77
| // Deduplicate in a stable way to get deterministic behaviour | ||
| let deduped_paths = groups | ||
| .iter() | ||
| .map(|group| &group.path) | ||
| .collect::<BTreeSet<_>>(); | ||
| group_requirements = deduped_paths | ||
| .into_iter() | ||
| .map(|path| RequirementsSource::PyprojectToml(path.to_owned())) | ||
| .collect::<Vec<_>>(); | ||
| requirements = &group_requirements[..]; |
There was a problem hiding this comment.
I started doing a cleanup pass to compute a BTreeMap<PathBuf, Vec<GroupName>> that would be used by subsequent steps but it was just more code and value threading for no real benefit over the current impl that just does a filter(group.path == path) later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal redux of #10861 to be compatible with
uv pip. I'm not 100% convinced the interaction with other sources is exactly what we want, but this is a good starting point.This implements the interface described in: pypa/pip#13065 (comment)
In that interface they add
--group <[path:]name>topip install,pip download, andpip wheel. Notably we do not defineuv pip downloadanduv pip wheel, so this PR only implements it foruv pip install.It was previously proposed we should also support this flag for
uv pip compile, which can be added trivially in this PR, but is currently not to minimize divergence.Fixes #8590
Current punts on #8969