Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uv sync reports selecting incorrect arch for numpy wheel #5836

Closed
tpgillam opened this issue Aug 6, 2024 · 7 comments · Fixed by #5845
Closed

uv sync reports selecting incorrect arch for numpy wheel #5836

tpgillam opened this issue Aug 6, 2024 · 7 comments · Fixed by #5845
Assignees
@charliermarsh
Labels
bug Something isn't working great writeup A wonderful example of a quality contribution 💜

Comments

@tpgillam
Copy link

tpgillam commented Aug 6, 2024

I'm using uv version 0.2.33. The following may be related to astral-sh/rye#1206

I have a fairly small python package, that comprises a C extension module, and a minimal wrapper around it. The extension module builds against numpy. I've recently been working to move over to using uv.

I'm running into issues when running uv sync, both locally (on MacOS arm64) as well as on GitHub (ubuntu x86_64 runner), where uv seems to select the wrong wheel for numpy.

For example, if I have a clean source tree (no *.so built, no .venv, no uv.lock), then I run:

uv sync --no-cache --verbose

Then on my mac I have just seen:

...<snip>...
DEBUG Searching for a compatible version of numpy (>=1.19.3)
DEBUG Selecting: numpy==2.0.1 [compatible] (numpy-2.0.1-cp310-cp310-macosx_10_9_x86_64.whl)
DEBUG No cache entry for: https://files.pythonhosted.org/packages/86/c0/025580db782c9be4c7de992e2cc4b2930c12ef8e0f26389c88089e2f8028/numpy-2.0.1-cp310-cp310-macosx_10_9_x86_64.whl.metadata
DEBUG Searching for a compatible version of pytest (>=5.4.1)
...<snip>...
...
ModuleNotFoundError: No module named 'numpy._core._multiarray_umath'

... at which point I'm guessing the incorrect architecture has caused the import error in numpy.

For something similar happening on GitHub actions you can see this log, running on x86_64 ubuntu 22.04, which has this snippet:

DEBUG Searching for a compatible version of numpy (*)
DEBUG Selecting: numpy==2.0.1 [compatible] (numpy-2.0.1-cp310-cp310-macosx_10_9_x86_64.whl)
DEBUG Tried 3 versions: numpy 1, setuptools 1, wheel 1

followed by a similar unhappiness upon attempts to install numpy.

Interestingly, it seems that uv does consistently pick the same incorrect wheel on each platform. (Intel Mac, it seems)

Whilst the uv sync commands both finish with non-zero exit codes, it does seem that the resulting virtualenv is usable. Including with a correctly built extension module for my library. e.g. I can immediately run:

uv run python -c "import numpy._core._multiarray_umath"

with no error. So I am wondering if actually there's just a minor logging problem wrt. the numpy wheel selected, and then there's an unrelated issue to do with building?

Full output of `uv sync --no-cache --verbose` 
DEBUG uv 0.2.33
warning: `uv sync` is experimental and may change without warning
DEBUG Found project root: `/Users/gillam/Documents/mt2`
DEBUG No workspace root found, using project root
DEBUG Searching for Python >=3.9 in managed installations or system path
DEBUG Searching for managed installations at `/Users/gillam/Library/Application Support/uv/python`
DEBUG Found managed installation `cpython-3.11.9-macos-aarch64-none`
DEBUG Found `cpython-3.11.9-macos-aarch64-none` at `/Users/gillam/Library/Application Support/uv/python/cpython-3.11.9-macos-aarch64-none/bin/python3` (managed installations)
Using Python 3.11.9
Creating virtualenv at: .venv
DEBUG Using request timeout of 30s
DEBUG Starting clean resolution
DEBUG Acquired lock for `/private/var/folders/52/445kdw9536n5gvb4gs4ttxq80000gn/T/.tmpTpoBIf/built-wheels-v3/editable/3feb24c11b9131ea`
DEBUG Preparing metadata for: mt2 @ file:///Users/gillam/Documents/mt2
DEBUG No static `PKG-INFO` available for: mt2 @ file:///Users/gillam/Documents/mt2 (MissingPkgInfo)
DEBUG Found static `pyproject.toml` for: mt2 @ file:///Users/gillam/Documents/mt2
DEBUG No workspace root found, using project root
DEBUG Solving with installed Python version: 3.11.9
DEBUG Solving with target Python version: >=3.9
DEBUG Adding direct dependency: mt2*
DEBUG Adding direct dependency: mt2[test]*
DEBUG Searching for a compatible version of mt2 @ file:///Users/gillam/Documents/mt2 (*)
DEBUG Adding transitive dependency for mt2==1.2.1: mt2==1.2.1
DEBUG Adding transitive dependency for mt2==1.2.1: mt2[test]==1.2.1
DEBUG Searching for a compatible version of mt2 @ file:///Users/gillam/Documents/mt2 (==1.2.1)
DEBUG Adding transitive dependency for mt2==1.2.1: numpy>=1.19.3
DEBUG Searching for a compatible version of mt2 @ file:///Users/gillam/Documents/mt2 (==1.2.1)
DEBUG Adding transitive dependency for mt2==1.2.1: pytest>=5.4.1
DEBUG No cache entry for: https://pypi.org/simple/numpy/
DEBUG No cache entry for: https://pypi.org/simple/pytest/
DEBUG Searching for a compatible version of numpy (>=1.19.3)
DEBUG Selecting: numpy==2.0.1 [compatible] (numpy-2.0.1-cp310-cp310-macosx_10_9_x86_64.whl)
DEBUG No cache entry for: https://files.pythonhosted.org/packages/86/c0/025580db782c9be4c7de992e2cc4b2930c12ef8e0f26389c88089e2f8028/numpy-2.0.1-cp310-cp310-macosx_10_9_x86_64.whl.metadata
DEBUG Searching for a compatible version of pytest (>=5.4.1)
DEBUG Selecting: pytest==8.3.2 [compatible] (pytest-8.3.2-py3-none-any.whl)
DEBUG No cache entry for: https://files.pythonhosted.org/packages/0f/f9/cf155cf32ca7d6fa3601bc4c5dd19086af4b320b706919d48a4c79081cf9/pytest-8.3.2-py3-none-any.whl.metadata
DEBUG Adding transitive dependency for pytest==8.3.2: iniconfig*
DEBUG Adding transitive dependency for pytest==8.3.2: packaging*
DEBUG Adding transitive dependency for pytest==8.3.2: pluggy>=1.5, <2
DEBUG Adding transitive dependency for pytest==8.3.2: exceptiongroup{python_version < '3.11'}>=1.0.0rc8
DEBUG Adding transitive dependency for pytest==8.3.2: tomli{python_version < '3.11'}>=1
DEBUG Adding transitive dependency for pytest==8.3.2: colorama{sys_platform == 'win32'}*
DEBUG No cache entry for: https://pypi.org/simple/packaging/
DEBUG No cache entry for: https://pypi.org/simple/iniconfig/
DEBUG No cache entry for: https://pypi.org/simple/pluggy/
DEBUG No cache entry for: https://pypi.org/simple/exceptiongroup/
DEBUG No cache entry for: https://pypi.org/simple/tomli/
DEBUG No cache entry for: https://pypi.org/simple/colorama/
DEBUG Searching for a compatible version of iniconfig (*)
DEBUG Selecting: iniconfig==2.0.0 [compatible] (iniconfig-2.0.0-py3-none-any.whl)
DEBUG No cache entry for: https://files.pythonhosted.org/packages/ef/a6/62565a6e1cf69e10f5727360368e451d4b7f58beeac6173dc9db836a5b46/iniconfig-2.0.0-py3-none-any.whl.metadata
DEBUG No cache entry for: https://files.pythonhosted.org/packages/88/5f/e351af9a41f866ac3f1fac4ca0613908d9a41741cfcf2228f4ad853b697d/pluggy-1.5.0-py3-none-any.whl.metadata
DEBUG Searching for a compatible version of packaging (*)
DEBUG Selecting: packaging==24.1 [compatible] (packaging-24.1-py3-none-any.whl)
DEBUG No cache entry for: https://files.pythonhosted.org/packages/08/aa/cc0199a5f0ad350994d660967a8efb233fe0416e4639146c089643407ce6/packaging-24.1-py3-none-any.whl.metadata
DEBUG Searching for a compatible version of pluggy (>=1.5, <2)
DEBUG Selecting: pluggy==1.5.0 [compatible] (pluggy-1.5.0-py3-none-any.whl)
DEBUG Searching for a compatible version of exceptiongroup{python_version < '3.11'} (>=1.0.0rc8)
DEBUG Selecting: exceptiongroup==1.2.2 [compatible] (exceptiongroup-1.2.2-py3-none-any.whl)
DEBUG Adding transitive dependency for exceptiongroup==1.2.2: exceptiongroup==1.2.2
DEBUG Adding transitive dependency for exceptiongroup==1.2.2: exceptiongroup{python_version < '3.11'}==1.2.2
DEBUG Searching for a compatible version of exceptiongroup{python_version < '3.11'} (==1.2.2)
DEBUG Selecting: exceptiongroup==1.2.2 [compatible] (exceptiongroup-1.2.2-py3-none-any.whl)
DEBUG No cache entry for: https://files.pythonhosted.org/packages/02/cc/b7e31358aac6ed1ef2bb790a9746ac2c69bcb3c8588b41616914eb106eaf/exceptiongroup-1.2.2-py3-none-any.whl.metadata
DEBUG Searching for a compatible version of exceptiongroup (==1.2.2)
DEBUG Selecting: exceptiongroup==1.2.2 [compatible] (exceptiongroup-1.2.2-py3-none-any.whl)
DEBUG Searching for a compatible version of tomli{python_version < '3.11'} (>=1)
DEBUG Selecting: tomli==2.0.1 [compatible] (tomli-2.0.1-py3-none-any.whl)
DEBUG Adding transitive dependency for tomli==2.0.1: tomli==2.0.1
DEBUG Adding transitive dependency for tomli==2.0.1: tomli{python_version < '3.11'}==2.0.1
DEBUG Searching for a compatible version of tomli{python_version < '3.11'} (==2.0.1)
DEBUG Selecting: tomli==2.0.1 [compatible] (tomli-2.0.1-py3-none-any.whl)
DEBUG No cache entry for: https://files.pythonhosted.org/packages/97/75/10a9ebee3fd790d20926a90a2547f0bf78f371b2f13aa822c759680ca7b9/tomli-2.0.1-py3-none-any.whl.metadata
DEBUG Searching for a compatible version of tomli (==2.0.1)
DEBUG Selecting: tomli==2.0.1 [compatible] (tomli-2.0.1-py3-none-any.whl)
DEBUG Searching for a compatible version of colorama{sys_platform == 'win32'} (*)
DEBUG Selecting: colorama==0.4.6 [compatible] (colorama-0.4.6-py2.py3-none-any.whl)
DEBUG Adding transitive dependency for colorama==0.4.6: colorama==0.4.6
DEBUG Adding transitive dependency for colorama==0.4.6: colorama{sys_platform == 'win32'}==0.4.6
DEBUG Searching for a compatible version of colorama{sys_platform == 'win32'} (==0.4.6)
DEBUG Selecting: colorama==0.4.6 [compatible] (colorama-0.4.6-py2.py3-none-any.whl)
DEBUG No cache entry for: https://files.pythonhosted.org/packages/d1/d6/3965ed04c63042e047cb6a3e6ed1a63a35087b6a609aa3a15ed8ac56c221/colorama-0.4.6-py2.py3-none-any.whl.metadata
DEBUG Searching for a compatible version of colorama (==0.4.6)
DEBUG Selecting: colorama==0.4.6 [compatible] (colorama-0.4.6-py2.py3-none-any.whl)
DEBUG Tried 9 versions: colorama 1, exceptiongroup 1, iniconfig 1, mt2 1, numpy 1, packaging 1, pluggy 1, pytest 1, tomli 1
DEBUG Split universal resolution took 0.268s
Resolved 9 packages in 269ms
DEBUG Using request timeout of 30s
DEBUG Identified uncached requirement: iniconfig==2.0.0
DEBUG Identified uncached requirement: mt2 @ file:///Users/gillam/Documents/mt2
DEBUG Identified uncached requirement: numpy==2.0.1
DEBUG Identified uncached requirement: packaging==24.1
DEBUG Identified uncached requirement: pluggy==1.5.0
DEBUG Identified uncached requirement: pytest==8.3.2
DEBUG Acquired lock for `/private/var/folders/52/445kdw9536n5gvb4gs4ttxq80000gn/T/.tmpTpoBIf/built-wheels-v3/editable/3feb24c11b9131ea`
DEBUG Building: mt2 @ file:///Users/gillam/Documents/mt2
DEBUG No cache entry for: https://files.pythonhosted.org/packages/0f/f9/cf155cf32ca7d6fa3601bc4c5dd19086af4b320b706919d48a4c79081cf9/pytest-8.3.2-py3-none-any.whl
DEBUG No cache entry for: https://files.pythonhosted.org/packages/08/aa/cc0199a5f0ad350994d660967a8efb233fe0416e4639146c089643407ce6/packaging-24.1-py3-none-any.whl
DEBUG No cache entry for: https://files.pythonhosted.org/packages/d1/d8/597b4b2e396a77cbec677c9de33bb1789d5c3b66d653cb723d00eb331e99/numpy-2.0.1-cp311-cp311-macosx_14_0_arm64.whl
DEBUG No cache entry for: https://files.pythonhosted.org/packages/ef/a6/62565a6e1cf69e10f5727360368e451d4b7f58beeac6173dc9db836a5b46/iniconfig-2.0.0-py3-none-any.whl
DEBUG No cache entry for: https://files.pythonhosted.org/packages/88/5f/e351af9a41f866ac3f1fac4ca0613908d9a41741cfcf2228f4ad853b697d/pluggy-1.5.0-py3-none-any.whl
INFO Ignoring empty directory
DEBUG Solving with installed Python version: 3.11.9
DEBUG Adding direct dependency: setuptools>=61.0
DEBUG Adding direct dependency: wheel*
DEBUG Adding direct dependency: numpy*
DEBUG No cache entry for: https://pypi.org/simple/setuptools/
DEBUG No cache entry for: https://pypi.org/simple/wheel/
DEBUG No cache entry for: https://files.pythonhosted.org/packages/1b/d1/9babe2ccaecff775992753d8686970b1e2755d21c8a63be73aba7a4e7d77/wheel-0.44.0-py3-none-any.whl.metadata
DEBUG Searching for a compatible version of setuptools (>=61.0)
DEBUG Selecting: setuptools==72.1.0 [compatible] (setuptools-72.1.0-py3-none-any.whl)
DEBUG No cache entry for: https://files.pythonhosted.org/packages/e1/58/e0ef3b9974a04ce9cde2a7a33881ddcb2d68450803745804545cdd8d258f/setuptools-72.1.0-py3-none-any.whl.metadata
DEBUG Searching for a compatible version of wheel (*)
DEBUG Selecting: wheel==0.44.0 [compatible] (wheel-0.44.0-py3-none-any.whl)
DEBUG Searching for a compatible version of numpy (*)
DEBUG Selecting: numpy==2.0.1 [compatible] (numpy-2.0.1-cp310-cp310-macosx_10_9_x86_64.whl)
DEBUG Tried 3 versions: numpy 1, setuptools 1, wheel 1
DEBUG Split specific environment resolution took 0.080s
DEBUG Installing in numpy==2.0.1, setuptools==72.1.0, wheel==0.44.0 in /private/var/folders/52/445kdw9536n5gvb4gs4ttxq80000gn/T/.tmpTpoBIf/builds-v0/.tmpG0r15D
DEBUG Identified uncached requirement: numpy==2.0.1
DEBUG Identified uncached requirement: setuptools==72.1.0
DEBUG Identified uncached requirement: wheel==0.44.0
DEBUG Downloading and building requirements for build: numpy==2.0.1, setuptools==72.1.0, wheel==0.44.0
DEBUG No cache entry for: https://files.pythonhosted.org/packages/86/c0/025580db782c9be4c7de992e2cc4b2930c12ef8e0f26389c88089e2f8028/numpy-2.0.1-cp310-cp310-macosx_10_9_x86_64.whl
DEBUG No cache entry for: https://files.pythonhosted.org/packages/e1/58/e0ef3b9974a04ce9cde2a7a33881ddcb2d68450803745804545cdd8d258f/setuptools-72.1.0-py3-none-any.whl
DEBUG No cache entry for: https://files.pythonhosted.org/packages/1b/d1/9babe2ccaecff775992753d8686970b1e2755d21c8a63be73aba7a4e7d77/wheel-0.44.0-py3-none-any.whl
DEBUG Installing build requirements: wheel==0.44.0, setuptools==72.1.0, numpy==2.0.1
DEBUG Calling `setuptools.build_meta.get_requires_for_build_editable()`
error: Failed to prepare distributions
  Caused by: Failed to fetch wheel: mt2 @ file:///Users/gillam/Documents/mt2
  Caused by: Failed to build: `mt2 @ file:///Users/gillam/Documents/mt2`
  Caused by: Build backend failed to determine extra requires with `build_editable()` with exit status: 1
--- stdout:

--- stderr:
Traceback (most recent call last):
  File "/private/var/folders/52/445kdw9536n5gvb4gs4ttxq80000gn/T/.tmpTpoBIf/builds-v0/.tmpG0r15D/lib/python3.11/site-packages/numpy/_core/__init__.py", line 23, in <module>
    from . import multiarray
  File "/private/var/folders/52/445kdw9536n5gvb4gs4ttxq80000gn/T/.tmpTpoBIf/builds-v0/.tmpG0r15D/lib/python3.11/site-packages/numpy/_core/multiarray.py", line 10, in <module>
    from . import overrides
  File "/private/var/folders/52/445kdw9536n5gvb4gs4ttxq80000gn/T/.tmpTpoBIf/builds-v0/.tmpG0r15D/lib/python3.11/site-packages/numpy/_core/overrides.py", line 8, in <module>
    from numpy._core._multiarray_umath import (
ModuleNotFoundError: No module named 'numpy._core._multiarray_umath'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/private/var/folders/52/445kdw9536n5gvb4gs4ttxq80000gn/T/.tmpTpoBIf/builds-v0/.tmpG0r15D/lib/python3.11/site-packages/numpy/__init__.py", line 114, in <module>
    from numpy.__config__ import show as show_config
  File "/private/var/folders/52/445kdw9536n5gvb4gs4ttxq80000gn/T/.tmpTpoBIf/builds-v0/.tmpG0r15D/lib/python3.11/site-packages/numpy/__config__.py", line 4, in <module>
    from numpy._core._multiarray_umath import (
  File "/private/var/folders/52/445kdw9536n5gvb4gs4ttxq80000gn/T/.tmpTpoBIf/builds-v0/.tmpG0r15D/lib/python3.11/site-packages/numpy/_core/__init__.py", line 49, in <module>
    raise ImportError(msg)
ImportError:

IMPORTANT: PLEASE READ THIS FOR ADVICE ON HOW TO SOLVE THIS ISSUE!

Importing the numpy C-extensions failed. This error can happen for
many reasons, often due to issues with your setup or how NumPy was
installed.

We have compiled some common reasons and troubleshooting tips at:

    https://numpy.org/devdocs/user/troubleshooting-importerror.html

Please note and check the following:

  * The Python version is: Python3.11 from "/private/var/folders/52/445kdw9536n5gvb4gs4ttxq80000gn/T/.tmpTpoBIf/builds-v0/.tmpG0r15D/bin/python"
  * The NumPy version is: "2.0.1"

and make sure that they are the versions you expect.
Please carefully study the documentation linked above for further help.

Original error was: No module named 'numpy._core._multiarray_umath'


The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "<string>", line 14, in <module>
  File "/private/var/folders/52/445kdw9536n5gvb4gs4ttxq80000gn/T/.tmpTpoBIf/builds-v0/.tmpG0r15D/lib/python3.11/site-packages/setuptools/build_meta.py", line 458, in get_requires_for_build_editable
    return self.get_requires_for_build_wheel(config_settings)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/private/var/folders/52/445kdw9536n5gvb4gs4ttxq80000gn/T/.tmpTpoBIf/builds-v0/.tmpG0r15D/lib/python3.11/site-packages/setuptools/build_meta.py", line 327, in get_requires_for_build_wheel
    return self._get_build_requires(config_settings, requirements=[])
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/private/var/folders/52/445kdw9536n5gvb4gs4ttxq80000gn/T/.tmpTpoBIf/builds-v0/.tmpG0r15D/lib/python3.11/site-packages/setuptools/build_meta.py", line 297, in _get_build_requires
    self.run_setup()
  File "/private/var/folders/52/445kdw9536n5gvb4gs4ttxq80000gn/T/.tmpTpoBIf/builds-v0/.tmpG0r15D/lib/python3.11/site-packages/setuptools/build_meta.py", line 313, in run_setup
    exec(code, locals())
  File "<string>", line 3, in <module>
  File "/private/var/folders/52/445kdw9536n5gvb4gs4ttxq80000gn/T/.tmpTpoBIf/builds-v0/.tmpG0r15D/lib/python3.11/site-packages/numpy/__init__.py", line 119, in <module>
    raise ImportError(msg) from e
ImportError: Error importing numpy: you should not try to import numpy from
        its source directory; please exit the numpy source tree, and relaunch
        your python interpreter from there.
---
@zanieb
Copy link
Member

zanieb commented Aug 6, 2024

I'm not the expert here, but I wonder if this is a case of https://github.com/astral-sh/uv/blob/main/docs/reference/resolver-internals.md#wheel-tags

@zanieb zanieb added the great writeup A wonderful example of a quality contribution 💜 label Aug 6, 2024
@charliermarsh
Copy link
Member

Does your package have a build dependency on NumPy? Does your package install successfully with pip install --use-pep517?

@tpgillam
Copy link
Author

tpgillam commented Aug 6, 2024

Does your package have a build dependency on NumPy?

Yes; currently I've got this encoded in the pyproject.toml in the build-system section:

[build-system]
requires = ["setuptools>=61.0", "wheel", "numpy"]
build-backend = "setuptools.build_meta"

Does your package install successfully with pip install --use-pep517?

Not 100% sure that this is the correct sequence, but it does seem to:

make clean && python -m venv .venv && .venv/bin/python -m pip install . --use-pep517

Processing /Users/gillam/Documents/mt2
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Collecting numpy>=1.19.3 (from mt2==1.2.1)
  Using cached numpy-2.0.1-cp312-cp312-macosx_14_0_arm64.whl.metadata (60 kB)
Using cached numpy-2.0.1-cp312-cp312-macosx_14_0_arm64.whl (5.0 MB)
Building wheels for collected packages: mt2
  Building wheel for mt2 (pyproject.toml) ... done
  Created wheel for mt2: filename=mt2-1.2.1-cp312-cp312-macosx_14_0_arm64.whl size=22691 sha256=ba281fed7795be296a918b7b740ae0f0c26fbf775484131aa7a1a3d6f39e012d
  Stored in directory: /private/var/folders/52/445kdw9536n5gvb4gs4ttxq80000gn/T/pip-ephem-wheel-cache-c91qdajx/wheels/ce/0e/3f/47c9588224465598f1723cc1ab6fb207cb549dbd3ad6f79a9c
Successfully built mt2
Installing collected packages: numpy, mt2
Successfully installed mt2-1.2.1 numpy-2.0.1

[notice] A new release of pip is available: 24.0 -> 24.2
[notice] To update, run: /Users/gillam/Documents/mt2/.venv/bin/python -m pip install --upgrade pip

@charliermarsh
Copy link
Member

Thanks -- that all looks correct. This is very strange.

@charliermarsh
Copy link
Member

I'm going to fork your repo and debug based on that Action. I'm actually so pumped that you have a repro there.

@charliermarsh charliermarsh self-assigned this Aug 6, 2024
@charliermarsh
Copy link
Member

I'm actively working on this, thank you.

@charliermarsh charliermarsh added the bug Something isn't working label Aug 7, 2024
@charliermarsh charliermarsh mentioned this issue Aug 7, 2024
Merged
charliermarsh added a commit that referenced this issue Aug 7, 2024
@charliermarsh
Avoid reusing incompatible distributions across lock and sync (#5845)
cccb682 
## Summary

We need to avoid using incompatible versions for build dependencies that
are also part of the resolved
environment. This is a very subtle issue, but: when locking, we don't
enforce platform
compatibility. So, if we reuse the resolver state to install, and the
install itself has to
preform a resolution (e.g., for the build dependencies of a source
distribution), that
resolution may choose incompatible versions.

The key property here is that there's a shared package between the build
dependencies and the
project dependencies.

Closes #5836.
@tpgillam
Copy link
Author

tpgillam commented Aug 7, 2024

Thank you for the rapid turnaround! Will test it for my case with the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
bug Something isn't working great writeup A wonderful example of a quality contribution 💜
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid reusing incompatible distributions across lock and sync astral-sh/uv
3 participants
@charliermarsh @zanieb @tpgillam