Skip to content

Update pre-commit dependencies #16465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 3, 2025
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 3, 2025

This PR contains the following updates:

Package Type Update Change
astral-sh/ruff-pre-commit repository patch v0.9.6 -> v0.9.9
crate-ci/typos repository minor v1.29.7 -> v1.30.0
python-jsonschema/check-jsonschema repository patch 0.31.1 -> 0.31.2
rbubley/mirrors-prettier repository patch v3.5.1 -> v3.5.2
woodruffw/zizmor-pre-commit repository minor v1.3.1 -> v1.4.1

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

Note: The pre-commit manager in Renovate is not supported by the pre-commit maintainers or community. Please do not report any problems there, instead create a Discussion in the Renovate repository if you have any questions.


Release Notes

astral-sh/ruff-pre-commit (astral-sh/ruff-pre-commit)

v0.9.9

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.9.9

v0.9.8

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.9.8

v0.9.7

Compare Source

See: https://github.com/astral-sh/ruff/releases/tag/0.9.7

crate-ci/typos (crate-ci/typos)

v1.30.0

Compare Source

[1.30.0] - 2025-03-01

Features

v1.29.10

Compare Source

[1.29.10] - 2025-02-25

Fixes
  • Also correct contaminent as contaminant

v1.29.9

Compare Source

[1.29.9] - 2025-02-20

Fixes
  • (action) Correctly get binary for some aarch64 systems

v1.29.8

Compare Source

[1.29.8] - 2025-02-19

Features
  • Attempt to build Linux aarch64 binaries
python-jsonschema/check-jsonschema (python-jsonschema/check-jsonschema)

v0.31.2

Compare Source

  • Update vendored schemas: dependabot, github-workflows, gitlab-ci, mergify, renovate,
    woodpecker-ci (2025-02-19)
rbubley/mirrors-prettier (rbubley/mirrors-prettier)

v3.5.2

Compare Source

woodruffw/zizmor-pre-commit (woodruffw/zizmor-pre-commit)

v1.4.1

Compare Source

See: https://github.com/woodruffw/zizmor/releases/tag/v1.4.1

v1.4.0

Compare Source

See: https://github.com/woodruffw/zizmor/releases/tag/v1.4.0


Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the internal An internal refactor or improvement label Mar 3, 2025
@dhruvmanila dhruvmanila requested a review from BurntSushi as a code owner March 3, 2025 07:29
Comment on lines +26 to +29
# Various third party dependencies uses `typ` as struct field names (e.g., lsp_types::LogMessageParams)
"typ",
# TODO: Remove this once the `TYP` redirects are removed from `rule_redirects.rs`
"TYP",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could change CFormatErrorType to use CFormatErrorKind and use kind field instead but I've avoided that for now as typ still needs to be ignored because it's used in third-party dependencies. TYP should be removed once the redirect is removed.

Copy link
Member

@dhruvmanila dhruvmanila Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm going to wait before merging this PR as this is an upstream crate and I'm not sure what's the process of updating it is. I could upstream this change (rust-lang/annotate-snippets-rs#182). cc @BurntSushi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm going to merge this, I've opened a PR to update this upstream as well. Happy to make any changes in a follow-up as needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is fine, but in general the idea is to minimize the diff between our code and upstream as much as possible. That way, if we want to bring in patches from upstream, it's less of a hassle.

I don't know how long this will last or if it's a viable long term strategy, but it's what has been guiding my changes to our vendored copy so far. e.g., There's a lot of other stuff I would want to change too and general code clean-up and what not, but specifically decided against it to keep the diff minimal.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that makes sense, I'll keep that in mind. The upstream PR is merged, so this shouldn't result in any diff.

Copy link
Contributor

github-actions bot commented Mar 3, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@dhruvmanila dhruvmanila merged commit 79a2c7e into main Mar 3, 2025
21 checks passed
@dhruvmanila dhruvmanila deleted the renovate/pre-commit-dependencies branch March 3, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants