build(deps): bump the production-dependencies group across 1 directory with 2 updates

.fmf/version

@@ -0,0 +1 @@
+1

.github/dependabot.yml

@@ -3,11 +3,21 @@
 
 version: 2
 updates:
-  - package-ecosystem: "cargo"
-    directory: "/"
+  - package-ecosystem: cargo
+    directory: /
     schedule:
-      interval: "weekly"
-  - package-ecosystem: "github-actions"
-    directory: "/"
+      interval: weekly
+    groups:
+      production-dependencies:
+        dependency-type: production
+      development-dependencies:
+        dependency-type: development
+  - package-ecosystem: github-actions
+    directory: /
     schedule:
-      interval: "weekly"
+      interval: weekly
+    groups:
+      production-dependencies:
+        dependency-type: production
+      development-dependencies:
+        dependency-type: development

.github/workflows/build.yml

@@ -4,7 +4,7 @@ on: # yamllint disable-line rule:truthy
   push:
     branches: [main]
     tags:
-      - "v*"
+      - v*
 
   pull_request:
     branches:
@@ -21,7 +21,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Check License Header
-        uses: apache/skywalking-eyes@a790ab8dd23a7f861c18bd6aaa9b012e3a234bce
+        uses: apache/skywalking-eyes@cd7b195c51fd3d6ad52afceb760719ddc6b3ee91
 
   build:
     runs-on: ubuntu-latest
@@ -39,7 +39,6 @@ jobs:
             libssl-dev \
             gcc-multilib \
             libelf-dev \
-            musl-tools
       - uses: actions/checkout@v4
       - uses: actions/checkout@v4
         with:
@@ -58,7 +57,9 @@ jobs:
           components: rustfmt, clippy, rust-src
           override: false
 
-      - uses: Swatinem/rust-cache@v2
+      ## TODO(astoycos) Deactivate the rust-cache action until we can determine
+      ## why it's freezing at the end of the install.
+      ## - uses: Swatinem/rust-cache@v2
 
       - name: Install cargo-llvm-cov
         uses: taiki-e/install-action@cargo-llvm-cov
@@ -87,67 +88,93 @@ jobs:
         run: |
           cargo +nightly clippy --all -- --deny warnings
 
+      - name: Check public API
+        run: cargo xtask public-api
+
       - name: Build
         run: cargo build --verbose
 
+      - name: Build manpages
+        run: cargo xtask build-man-page
+
+      - name: Build CLI TAB Completion
+        run: cargo xtask build-completion
+
       ## If the push is a tag....build and upload the release bpfman binaries to an archive
       - name: Build-Release
         if: startsWith(github.ref, 'refs/tags/v')
         run: |
-          rustup target add x86_64-unknown-linux-musl
-          cargo build --release --target x86_64-unknown-linux-musl
+          cargo build --release --target x86_64-unknown-linux-gnu
 
       - name: Package-Binaries
         if: startsWith(github.ref, 'refs/tags/v')
         run: |
-          tar -czvf bpfman-linux-x86_64.tar.gz ./target/x86_64-unknown-linux-musl/release/bpfman
+          cd target/x86_64-unknown-linux-gnu/release
+          tar -czvf bpfman-linux-x86_64.tar.gz bpfman bpfman-rpc bpfman-ns bpf-metrics-exporter bpf-log-exporter
 
       - name: Archive bpfman Release Binaries
         if: startsWith(github.ref, 'refs/tags/v')
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: bpfman-release
           path: |
-            ./bpfman-linux-x86_64.tar.gz
+            ./target/x86_64-unknown-linux-gnu/release/bpfman-linux-x86_64.tar.gz
 
       - name: Run tests
         run: cargo llvm-cov test --all-features -p bpfman -p bpfman-api --lcov --output-path lcov.info
         env:
           RUST_BACKTRACE: full
 
       - name: Archive Rust code coverage results
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: coverage
+          name: coverage-rust
           path: lcov.info
           if-no-files-found: error
 
   ## Build go modules
   build-go:
     runs-on: ubuntu-latest
+    # k8s codegen requires this to be set
+    env:
+      GOPATH: ${{ github.workspace }}
     defaults:
       run:
-        working-directory: ./bpfman-operator
+        ## For us to run the controller-gen generate commands from within
+        ## github actions the package name MUST match the directory layout
+        ## (i.e `GOPATH/src/github.com/bpfman/bpfman`). Otherwise when
+        ## running `make generate` generated code is deposited at
+        ## `home/runner/work/bpfman/bpfman/bpfman-operator/PKG_NAME` instead
+        ## of in `home/runner/work/bpfman/bpfman/bpfman-operator/pkg/client/...`.
+        ## This is annoying and gross but cannot be resolved until
+        ## https://github.com/kubernetes/kubernetes/issues/86753 is properly
+        ## addressed.
+        working-directory: ${{ env.GOPATH }}/src/github.com/bpfman/bpfman/bpfman-operator
     steps:
       - uses: actions/checkout@v4
-      - uses: actions/setup-go@v4
         with:
-          go-version: "1.21"
+          path: ${{ env.GOPATH }}/src/github.com/bpfman/bpfman
+
+      - uses: actions/setup-go@v5
+        with:
+          # prettier-ignore
+          go-version: '1.21' # yamllint disable-line rule:quoted-strings
 
       - name: Go mod check
-        working-directory: ${{ github.workspace }}
         run: |
           go mod tidy
-          git diff --exit-code go.mod go.sum
+          git diff --exit-code ../go.mod ../go.sum
 
       - name: Lint
-        uses: golangci/golangci-lint-action@v3
+        uses: golangci/golangci-lint-action@v6
         with:
+          ## https://github.com/golangci/golangci-lint-action/issues/369
+          working-directory: ${{ env.GOPATH }}/src/github.com/bpfman/bpfman
           version: v1.54.2
           skip-cache: true
           skip-pkg-cache: true
           skip-build-cache: true
-          args: -v --timeout 5m --enable=gofmt
+          args: -v --timeout 5m
 
       - name: Build Examples
         run: |
@@ -163,15 +190,28 @@ jobs:
         run: make test
 
       - name: Archive Go code coverage results
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: coverage
-          path: ./bpfman-operator/cover.out
+          name: coverage-go
+          path: ${{ env.GOPATH }}/src/github.com/bpfman/bpfman/bpfman-operator/cover.out
           if-no-files-found: error
 
+  build-docs:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-python@v5
+        with:
+          python-version: 3.x
+      - name: Mkdocs Build
+        run: |
+          pip install mkdocs-material
+          pip install -r requirements.txt
+          mkdocs build --strict
+
   basic-integration-tests:
     runs-on: ubuntu-latest
-    needs: ["build", "build-go"]
+    needs: [build, build-go, build-docs]
     env:
       CARGO_TERM_COLOR: always
     steps:
@@ -209,31 +249,43 @@ jobs:
       - name: Build bpfman
         run: cargo build --verbose
 
+      - name: Build manpages
+        run: cargo xtask build-man-page
+
+      - name: Build CLI TAB Completion
+        run: cargo xtask build-completion
+
       - name: Run the bpfman installer
         run: sudo ./scripts/setup.sh install
 
       - name: Give certs time to be created
         run: sleep 5
 
       - name: Verify the bpfman systemd service is active
-        run: systemctl is-active bpfman
+        run: systemctl is-active bpfman.socket
 
       - name: Verify the CLI can reach bpfman
         run: sudo bpfman list
 
+      - name: Verify the manpages are installed
+        run: man bpfman list
+
       - name: Stop the bpfman systemd service
-        run: sudo systemctl stop bpfman
+        run: |
+          sudo systemctl stop bpfman
+          sudo ./scripts/setup.sh uninstall
 
       - name: Run integration tests
         run: cargo xtask integration-test
 
   kubernetes-integration-tests:
-    needs: ["build", "build-go"]
+    needs: [build, build-go, build-docs]
     runs-on: ubuntu-latest
     env:
-      BPFMAN_IMG: "quay.io/bpfman/bpfman:int-test"
-      BPFMAN_AGENT_IMG: "quay.io/bpfman/bpfman-agent:int-test"
-      BPFMAN_OPERATOR_IMG: "quay.io/bpfman/bpfman-operator:int-test"
+      BPFMAN_IMG: quay.io/bpfman/bpfman:int-test
+      BPFMAN_AGENT_IMG: quay.io/bpfman/bpfman-agent:int-test
+      BPFMAN_OPERATOR_IMG: quay.io/bpfman/bpfman-operator:int-test
+      XDP_PASS_PRIVATE_IMAGE_CREDS: ${{ secrets.XDP_PASS_PRIVATE_IMAGE_CREDS }}
     steps:
       - name: Install dependencies
         run: |
@@ -246,12 +298,13 @@ jobs:
             libbpf-dev
 
       - name: setup golang
-        uses: actions/setup-go@v4
+        uses: actions/setup-go@v5
         with:
-          go-version: "^1.19"
+          # prettier-ignore
+          go-version: '1.21' # yamllint disable-line rule:quoted-strings
 
       - name: cache go modules
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: ~/go/pkg/mod
           key: ${{ runner.os }}-build-codegen-${{ hashFiles('**/go.sum') }}
@@ -283,27 +336,31 @@ jobs:
       ## Upload diagnostics if integration test step failed.
       - name: upload diagnostics
         if: ${{ failure() }}
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: kubernetes-integration-test-diag
           path: /tmp/ktf-diag*
           if-no-files-found: ignore
 
   coverage:
-    needs: ["build", "build-go"]
+    needs: [build, build-go, build-docs]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
 
-      - name: Download coverage artifacts
-        uses: actions/download-artifact@v3
+      - name: Download golang coverage artifacts
+        uses: actions/download-artifact@v4
         with:
-          name: coverage
+          name: coverage-go
+
+      - name: Download rust coverage artifacts
+        uses: actions/download-artifact@v4
+        with:
+          name: coverage-rust
 
       - name: Upload coverage to Codecov
-        uses: codecov/codecov-action@v3
+        uses: codecov/codecov-action@v4
         with:
-          fail_ci_if_error: true
           files: ./cover.out,./lcov.info
           verbose: true
 
@@ -312,7 +369,7 @@ jobs:
   # Publish's bpfman and bpfman-api crates to crates.io
   release:
     if: startsWith(github.ref, 'refs/tags/v')
-    needs: ["build"]
+    needs: [build]
     environment: crates.io
     runs-on: ubuntu-latest
     steps:
@@ -322,33 +379,42 @@ jobs:
         run: |
           echo "RELEASE_VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
 
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: bpfman-release
 
       - name: release
-        uses: softprops/action-gh-release@v1
+        uses: softprops/action-gh-release@v2
         with:
           body_path: ./changelogs/CHANGELOG-${{ env.RELEASE_VERSION }}.md
           files: |
             bpfman-linux-x86_64.tar.gz
 
-      ## TODO once we're using an aya mainline version
-      # - name: publish bpfman crate
-      #   run: cargo publish -p bpfman --token ${{ secrets.BPFMAN_DEV_TOKEN }}
+      - name: publish bpfman-csi crate
+        run: cargo publish -p bpfman-csi --token ${{ secrets.BPFMAN_DEV_TOKEN }}
+
+      - name: publish bpfman crate
+        run: cargo publish -p bpfman --token ${{ secrets.BPFMAN_DEV_TOKEN }}
 
       - name: publish bpfman-api crate
         run: cargo publish -p bpfman-api --token ${{ secrets.BPFMAN_DEV_TOKEN }}
 
+      - name: publish bpf-log-exporter crate
+        run: cargo publish -p bpfman-log-exporter --token ${{ secrets.BPFMAN_DEV_TOKEN }}
+
+      - name: publish bpf-metrics-exporter crate
+        run: cargo publish -p bpfman-metrics-exporter --token ${{ secrets.BPFMAN_DEV_TOKEN }}
+
   build-workflow-complete:
     needs:
       [
-        "check-license",
-        "build",
-        "build-go",
-        "coverage",
-        "basic-integration-tests",
-        "kubernetes-integration-tests",
+        check-license,
+        build,
+        build-go,
+        build-docs,
+        coverage,
+        basic-integration-tests,
+        kubernetes-integration-tests,
       ]
     runs-on: ubuntu-latest
     steps: