-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Padding transform #133
Padding transform #133
Conversation
Thanks for the PR and for the patience :) Reviewing this is still on my TODO list |
I see two test failures on my end (when running on a CUDA-capable machine). Only the first of them is related to this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't listened to the outputs yet. I promise to do that later though 😄
Hi @iver56, I have updated the PR. |
But the cuda test is still broken. Should I fix it? |
@iver56 Oops, my bad. Must be fixed now. Since I don't have GPU in my local machine, it skips Cuda tests every time. |
Ah, I see. Thanks for the fix 👍 I'm on vacation these days, so response will be slow until at least tuesday. Thanks for your patience :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! It only does zero padding for now, so we could add support for wrap and reflect later
Thanks for the contribution 😄
Added padding transform #91