xpp: Fix build with 32-bits kernel #32
Conversation
The CLA will need to be signed for this to be reviewed/merged. |
|
Done |
|
CLA was signed, do you have additional comments? |
I'm not a maintainer of this repo. We're going to have to wait for someone with the right keys to do something. That could take quite a while... average merge time at the moment is 3-4 years :) |
There was a problem hiding this comment.
Finally got around to testing this, and this fixes the issue as expected.
You might consider amending the commit title to "xpp: Fix build on 32-bit kernels", but it doesn't look like the current maintainer is enforcing any standards as far as the commit messages go so I presume this should be fine as is.
For the time being, I've also included the patch in PhreakScript[1] until merged upstream - still not sure when that will be...
ffontaine
changed the title
Use div_s64 or div_s64_rem to fix the following build failure on 32-bits kernels: ERROR: modpost: "__divdi3" [/home/fabrice/buildroot/output/build/dahdi-linux-5c840cf43838e0690873e73409491c392333b3b8/drivers/dahdi/xpp/xpp_usb.ko] undefined! ERROR: modpost: "__udivdi3" [/home/fabrice/buildroot/output/build/dahdi-linux-5c840cf43838e0690873e73409491c392333b3b8/drivers/dahdi/xpp/xpp_usb.ko] undefined! ERROR: modpost: "__moddi3" [/home/fabrice/buildroot/output/build/dahdi-linux-5c840cf43838e0690873e73409491c392333b3b8/drivers/dahdi/xpp/xpp.ko] undefined! ERROR: modpost: "__divdi3" [/home/fabrice/buildroot/output/build/dahdi-linux-5c840cf43838e0690873e73409491c392333b3b8/drivers/dahdi/xpp/xpp.ko] undefined! [Retrieved from: https://git.buildroot.net/buildroot/tree/package/dahdi-linux/0002-fix-build-with-32-bits-kernel.patch] Signed-off-by: Fabrice Fontaine <[email protected]>
Use div_s64 or div_s64_rem to fix the following build failure on 32-bits kernels:
[Retrieved from:
https://git.buildroot.net/buildroot/tree/package/dahdi-linux/0002-fix-build-with-32-bits-kernel.patch]