Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set both background and border color of element #473

Open
ms-mialingvo opened this issue Jan 27, 2025 · 3 comments
Open

Set both background and border color of element #473

ms-mialingvo opened this issue Jan 27, 2025 · 3 comments
Labels
Milestone

Comments

@ms-mialingvo
Copy link
Collaborator

Currently it's only possible to set either the background color or the border color. Allowing to set both - as possible in some other AAC apps - allows further individualization. In most cases this would be to set the cell background color in one light color and the border in dark of the same color (e.g. background color light blue, border color dark blue).

This should be possible on element level and then with #299 for multiple cells at once as well as eventually for #418. (#418 would allow users to quickly adapt the colors of an existing grid to their needs if the word form (verb, noun etc.) is set. Like, in various countries or even in various regions there are specific color codes for word forms (e.g. verbs are blue, nouns are brown) in schools and being able to adapt that quickly saves a lot of time and improves teachers's willingness to work with the boards.)

@ms-mialingvo ms-mialingvo added this to the Mialingvo milestone Jan 27, 2025
@klues
Copy link
Contributor

klues commented Jan 27, 2025

OK, so border and background will always be the same color, but different tones? I wonder if then there just should be one or two additional options here:

Image

Options like:

  • Color both (border lighter)
  • Color both (border darker)

and then based on the current color theme the darker/lighter colors are determined. Because styling elements on element-level sounds tedious for me. There could also be something like "secondary color scheme" which then defines the secondary colors for border / background next to the primary color scheme. For instance

  • color mode: color background
  • color scheme (the existing setting): Fitzgerald (light) (or any other maybe at some time self-configured scheme)
  • secondary color scheme: Fitzgerald (dark)
  • so background would be colored light and the border dark, since the secondary color scheme is set (no need for color mode: color both there, just setting the secondary color scheme determines if both are colored or not)

@ms-mialingvo
Copy link
Collaborator Author

OK, so border and background will always be the same color, but different tones? I

Yes, I can't think of any use for mixing colors within the same element. I also can't think of an use where the background would be a darker tone and the border a lighter tone. (Except for high-contrast boards but there the background would be uniformely dark grey or black, which is already possible).

It took me quite a moment to understand your second suggestion which is why it will also be tricky for an user to understand intuitively ("if I set a secondary color scheme it defines the color of either the background or the border based on what I have not set in the color mode") if I understand your suggestion correctly. In terms of how it could function it sounds good, I'm just struggling to find a good naming/wording/info-text so it's clearer. I wonder if an (i) To set both, select a scheme from the secondary color scheme would suffice for clarity.

Because styling elements on element-level sounds tedious for me.

I lost so much time because I didn't realise at first that it was possible to style multiple elements simultaneously in TD Snap so it is indeed tedious! ;)

I just thought that it might be faster to implement on element level than #418. But if it's possible to set on grid set level, element level wouldn't be necessary I think.

@ms-mialingvo
Copy link
Collaborator Author

ms-mialingvo commented Jan 29, 2025

But if it's possible to set on grid set level, element level wouldn't be necessary I think.

After thinking more about it, element level (and multiple-selected-elements-level) would still make sense, because if you "just" want to colorise say the "category"-buttons, quickly selecting them and adding the format is more intuitive and direct than having to define them as a word type first, for the color scheme to apply.
In that case, the suggestion above wouldn't work well because it can't be set up well on element level in a similar way / with similar wording.

Hmm, what about a color mode color both
and then Color Scheme for Categories: background, Color Scheme for Categories: border

And then on element level parallel
background color, border color
?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants