Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate translation #171

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

Noirox1
Copy link
Contributor

@Noirox1 Noirox1 commented Jun 4, 2024

Integrated Translation to German and English, as well as baseline support for portuguese as interest in that was indicated in #167. This also makes progress on #155, I will update the wiki to match current progress in the near future.

Noirox1 and others added 7 commits May 13, 2024 23:56
TODO: Bugfix translation file generation
This commit translates the calendar, feed and mensa folders. The more and wallet folders are to be translated. Untranslated files did not include hardcoded strings in the first place.
Copy link
Member

@domai-tb domai-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Noirox1, first of all, thanks for your work! ^~^ 👍🏼

I checked your changes and it looks good so far. The only thing, I'm a bit confused, did you edit any file in lib/l10n manually? 😅 Usually, you can generate them by using the flutter_localizations package. This will generate these classes based on the .arb-files. Additionally translation can than be added really easily like @BizarrePenguin did in #167.

Can you adjust the PR to use the flutter_localizations plugin and automatic generation? Thanks!

@Noirox1
Copy link
Contributor Author

Noirox1 commented Aug 31, 2024

Hey @domai-tb, thanks for reviewing! Yes, I did indeed edit the files manually, since the automatic generation (like many features of flutter) did not work on my machine. Since the ARB files are simply a different formatting, I quickly copied over my translations and search/replaced the format differences, so they can now easily be edited in the future. Thanks for catching that and reminding me!

As a sidenote, my internship has already ended in July, so I might not find the time to make any more substantial changes than this, if you see any other work that needs to be done, feel free to contribute to this branch yourself!

@henry-herrmann
Copy link
Member

@domai-tb @Noirox1 I swiftly implemented the changes necessary for automatic generation of the l10n files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants