-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate translation #171
base: master
Are you sure you want to change the base?
Conversation
TODO: Bugfix translation file generation
This commit translates the calendar, feed and mensa folders. The more and wallet folders are to be translated. Untranslated files did not include hardcoded strings in the first place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Noirox1, first of all, thanks for your work! ^~^ 👍🏼
I checked your changes and it looks good so far. The only thing, I'm a bit confused, did you edit any file in lib/l10n
manually? 😅 Usually, you can generate them by using the flutter_localizations package. This will generate these classes based on the .arb
-files. Additionally translation can than be added really easily like @BizarrePenguin did in #167.
Can you adjust the PR to use the flutter_localizations
plugin and automatic generation? Thanks!
Hey @domai-tb, thanks for reviewing! Yes, I did indeed edit the files manually, since the automatic generation (like many features of flutter) did not work on my machine. Since the ARB files are simply a different formatting, I quickly copied over my translations and search/replaced the format differences, so they can now easily be edited in the future. Thanks for catching that and reminding me! As a sidenote, my internship has already ended in July, so I might not find the time to make any more substantial changes than this, if you see any other work that needs to be done, feel free to contribute to this branch yourself! |
Integrated Translation to German and English, as well as baseline support for portuguese as interest in that was indicated in #167. This also makes progress on #155, I will update the wiki to match current progress in the near future.