-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix code quality errors #265
base: master
Are you sure you want to change the base?
Conversation
Hello @arpitjain099, Thank you in advance, and sorry for commenting somewhere unrelated. All the best! |
@eliegoudout no I do not. I didn't know this repo is not being actively managed anymore. This repo is being used by a lot of devs (more than 5M downloads from PyPI). Surprised it's not being managed anymore. |
I'm the project owner and maintainer. I do and intend to maintain this project going forward but it is a hobby project, and it takes a back seat after the day job, family, sport, and other hobbies. In practice, that means
@eliegoudout pull request #221 seems good, it doesn't break stuff as far as I can see. I'm not sure about printing warnings. I'd rather prefer it to do its best silently. There're some code formatting issues, but nothing that black cannot fix. |
@astanin thank you for the reply. I see that there are some merge conflicts now - let me resolve them and send the PR back to you for review. |
I ran CodeQL scanning on the project and found the following 10 alerts.
I fixed 4 alerts and made this PR. Please review