Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code quality errors #265

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

arpitjain099
Copy link

I ran CodeQL scanning on the project and found the following 10 alerts.

image

I fixed 4 alerts and made this PR. Please review
image

arpitjain099

This comment was marked as duplicate.

tabulate/__init__.py Outdated Show resolved Hide resolved
@eliegoudout
Copy link
Contributor

Hello @arpitjain099,
Sorry for asking you here, but do you have the rights to review / merge PRs? I think this repo is lacking activity recently and I would really like to have #221 merged for a project. It closes 11 issues as well as adding functionality.

Thank you in advance, and sorry for commenting somewhere unrelated.

All the best!

@arpitjain099
Copy link
Author

@eliegoudout no I do not. I didn't know this repo is not being actively managed anymore. This repo is being used by a lot of devs (more than 5M downloads from PyPI). Surprised it's not being managed anymore.

@astanin
Copy link
Owner

astanin commented Apr 30, 2023

Hi @arpitjain099 @eliegoudout

I'm the project owner and maintainer. I do and intend to maintain this project going forward but it is a hobby project, and it takes a back seat after the day job, family, sport, and other hobbies. In practice, that means

  1. I review and merge submissions approximately once or twice per year

  2. Priority is on maintaining backwards compatibility and supporting new Python versions

  3. Low priority stuff that might never be merged: code formatting, changing too many lines of code, new dependencies, introducing new workflows, integrating with yet another CI service.

  4. New features: medium priority. I consider this project to be good enough as it is. It was certainly good for my needs. I try to avoid breaking old use cases.

  5. Submitting pull requests is the best way to change/fix something in the project.

  6. Small focused PRs are more likely to be merged. I might not have time to cherry-pick changes from a huge PR which may also conflict with something else.

  7. Expect ~ 6 months lead time before it goes into a release.

@eliegoudout pull request #221 seems good, it doesn't break stuff as far as I can see. I'm not sure about printing warnings. I'd rather prefer it to do its best silently. There're some code formatting issues, but nothing that black cannot fix.

@arpitjain099
Copy link
Author

@astanin thank you for the reply. I see that there are some merge conflicts now - let me resolve them and send the PR back to you for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants