Add support for alignments in Markdown tables #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdeldycke
force-pushed
the
markdown-table-alignments
branch
from
0b32778
to
82fdf25
Compare
This was referenced Apr 4, 2023
kdeldycke
force-pushed
the
markdown-table-alignments
branch
from
82fdf25
to
507264e
Compare
Closes astanin#53, superseds astanin#260.
kdeldycke
force-pushed
the
markdown-table-alignments
branch
from
507264e
to
f4df50c
Compare
|
All tests are passing and successful. This PR is ready to be merged upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds supports for column alignments for GitHub-Flavored Markdown (i.e. the
githubtable format). This has been requested on issue #53 and reuse the same code as thepipeformat.Additionally, this PR allows the elements used to produce the alignments segments to be configured by the way of the
begin=,hline=,sep=andend=parameters. This will help support of other formats in the future.And finally, this PR tweak the
githubformat to introduce a space separation between the pipes separating the cells of the table. This is to conform to the GitHub Flavored Markdown Spec.This closes #53 and also supersedes #260.