Fix invalid read syntax error when result overlays are hidden #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While running ob-async I kept getting this error: if: Invalid read syntax: "#" When I enabled async-debug I found the culprit, overlays for babel results that I had toggled to be hidden: ELISP> org-babel-hide-result-overlays (#<overlay from 13045 to 13045 in wat.org>) This change excludes `org-babel-hide-result-overlays' specifically, but a more general fix would test the value of each variable sent to the subprocess to ensure it can be serialized.
spacebat
changed the title
|
Thanks for this pr which help me finding out the problem ， "'error in process sentinel: async-handle-result: Invalid read syntax: "#"' . But I don't think hiding org-babel-hide-result-overlays is enough, because other variable may cause same phenomenon. Maybe we could wrap |
|
Turns out setting |
|
Great catch, I was also struggling with this and failed to find a solution until I noticed this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent org-babel-hide-result-overlays from being inherited by the async process, because overlays are not readable and lead to the following error:
if: Invalid read syntax: "#"
See commit message.