Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is couple of concerns:
headless()
each time they face the issueCould not initialize class sun.awt.X11GraphicsEnvironment
, on the other - there are can be users which have AWT in their project and they don't need to be headless and they will be struggling to seek the cause. So here is the choice between having issue and writeheadless
each time or having issue and seek of it and writeheadless(false)
. My opinion having property by default will be better for bigger amount of users.Another way of implementing this is having Singleton of Shuttebug class and return the instance of it.
in this case it is possible to write like
Shutterbug.headless(false).shootPage(driver);
, but we will call static methods on instance, which is 😩 you know.