Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update Rust crate libtest-mimic to 0.8.0 #369

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 1, 2024

This PR contains the following updates:

Package Type Update Change
libtest-mimic dependencies minor 0.7.0 -> 0.8.0

Release Notes

LukasKalbertodt/libtest-mimic (libtest-mimic)

v0.8.1

Compare Source

  • Fix bug when executing trial on fewer threads than trials (thanks @​hanna-kruppe for catching this)

v0.8.0

Compare Source

  • Breaking: bump MSRV to 1.65
  • Remove threadpool dependency, getting rid of memory leaks observed when running under valgrind (thanks @​Felix-El) in #​46
  • Switch from termcolor to anstream to get rid of duplicate dependencies (thanks @​hanna-kruppe) in #​44
  • Bump dev-dependency fastrand to 2 (thanks @​alexanderkjall) in #​47
  • Fix outdated docs

Configuration

📅 Schedule: Branch creation - "before 5am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@coveralls
Copy link

coveralls commented Nov 1, 2024

Pull Request Test Coverage Report for Build 14368170564

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.323%

Totals Coverage Status
Change from base Build 14248011671: 0.0%
Covered Lines: 1404
Relevant Lines: 2790

💛 - Coveralls

@renovate renovate bot force-pushed the renovate/libtest-mimic-0.x branch from b438847 to 1a078ee Compare November 7, 2024 02:15
@renovate renovate bot force-pushed the renovate/libtest-mimic-0.x branch from 1a078ee to 33abf73 Compare December 16, 2024 21:59
@musicinmybrain
Copy link

I just tried this locally, and cargo test --workspace passed. The logs from the failing CI runs have been cleaned up, so it’s not possible to tell what went wrong. I wonder if this would succeed now if it were re-triggered.

@renovate renovate bot force-pushed the renovate/libtest-mimic-0.x branch from 33abf73 to 8e46f42 Compare April 9, 2025 22:29
@epage
Copy link
Contributor

epage commented Apr 9, 2025

  error[E0277]: `Sender<(Outcome, TestInfo)>` cannot be shared between threads safely
     --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/libtest-mimic-0.8.1/src/lib.rs:521:29
      |
  521 |                   scope.spawn(|| {
      |  _______________________-----_^
      | |                       |
      | |                       required by a bound introduced by this call
  522 | |                     loop {
  523 | |                         // Get next test to process from the iterator.
  524 | |                         let Some(trial) = iter.lock().unwrap().next() else {
  ...   |
  539 | |                     }
  540 | |                 });
      | |_________________^ `Sender<(Outcome, TestInfo)>` cannot be shared between threads safely
      |
      = help: the trait `Sync` is not implemented for `Sender<(Outcome, TestInfo)>`
      = note: required for `&Sender<(Outcome, TestInfo)>` to implement `Send`
  note: required because it's used within this closure
     --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/libtest-mimic-0.8.1/src/lib.rs:521:29
      |
  521 |                 scope.spawn(|| {
      |                             ^^
  note: required by a bound in `Scope::<'scope, 'env>::spawn`

@epage
Copy link
Contributor

epage commented Apr 9, 2025

@musicinmybrain
Copy link

Makes sense – MSRV is the issue. Thanks for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants