Add a history page (static) #967
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love it. I'm voting for Postgres as the default data store, since it's also supported by langchain vector stores - see PGVector But, great proof of concept :) |
|
@ElishaKay Yes, integrating with Postgres is certainly viable if that’s the plan. I’m using SQLite for now just for simplicity—it’s just a single file for the database, after all |
|
Any update on this PR? |
muditjuneja
reviewed
Jan 5, 2025
backend/server/database.py
Outdated
| from datetime import datetime | ||
|
|
||
| def init_db(): | ||
| conn = sqlite3.connect('research_history.db') |
There was a problem hiding this comment.
Can you move the db name as a const at the top and reuse the same name in other functions?
muditjuneja
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is simply to add a static history page and store the generated reports in a local SQLite database. Here are some screenshots for reference:
This is more of a proposal, but I think it might be more straightforward to submit a PR. Looking forward to the feedback!