Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Coverage: Ignore Admin_Settings::add_settings_field_callback() #251

Conversation

costdev
Copy link
Contributor

@costdev costdev commented Dec 19, 2024

This should be tested with E2E tests instead.

Pull Request

What changed?

Ignored Admin_Settings::add_settings_field_callback() from coverage reports.

Why did it change?

To ensure this method doesn't unnecessarily affect coverage reports.

Did you fix any specific issues?

See #216

CERTIFICATION

By opening this pull request, I do agree to abide by the Code of Conduct and be bound by the terms of the Contribution Guidelines in effect on the date and time of my contribution as proven by the revision information in GitHub.

This should be tested with E2E tests instead.
@costdev costdev marked this pull request as ready for review December 19, 2024 18:27
@costdev costdev merged commit c91e36b into aspirepress:main Dec 19, 2024
5 checks passed
@costdev costdev mentioned this pull request Dec 19, 2024
44 tasks
@costdev costdev deleted the tests_ignore_admin_settings_add_settings_field_callback_from_coverage branch December 19, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant