Use the full domain name #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the full domain name instead of attempting to extract the top level TLD
afragen
approved these changes
Nov 29, 2024
|
Thanks @namithj! I'll review this one and run some tests for multisite. |
costdev
reviewed
Nov 29, 2024
includes/class-utilities.php
Outdated
| $domain_parts = explode( '.', $domain_name ); | ||
| return sanitize_text_field( implode( '.', array_slice( $domain_parts, -2 ) ) ); | ||
| public static function get_site_domain() { | ||
| $site_url = get_site_url(); |
There was a problem hiding this comment.
In multisite, plugins can only be installed on the network level. Therefore, the URL for the API should be the main site's URL.
With a multisite setup of:
- First site: https://my-site.com (main site)
- Second site: https://my-other-site.com
When on Second site, get_site_url() will return https://my-other-site.com.
Use network_site_url() instead, as it will return https://my-site.com.
costdev
requested changes
Nov 29, 2024
network_site_url instead of get_site_url
|
I have pushed an update, technically it wouldn't matter as the settings page can only run from the main site of the network but no harm in having the proper function in place. |
costdev
reviewed
Nov 30, 2024
Signed-off-by: Colin Stewart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the full domain name instead of attempting to extract the top level TLD
Pull Request
What changed?
Changed behavior of API Key call to use the full domain name instead of trying to extract the top TLD which can lead to parsing issues
Why did it change?
Extracting the top TLD was an unnecessary complication which is not required.
Did you fix any specific issues?
Fixes #194
CERTIFICATION
By opening this pull request, I do agree to abide by the Code of Conduct and be bound by the terms of the Contribution Guidelines in effect on the date and time of my contribution as proven by the revision information in GitHub.