new script-based update strategy #44
Merged
+696
−360
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What changed?
AS is no longer using the internal svn listing/tracking mechanisms to determine which plugins to fetch, but instead some shell scripts in
svn/bin
that return the list of changed slugs since a given past date (default 2 days), which are then fed to the fetch command to grab unconditionally. To avoid re-fetching on every run, slugs that have been checked recently are skipped, though all metadata still in the check interval will eventually be re-checked every 4 hours (also configurable).Why did it change?
This greatly simplifies the revision state tracking logic in AspireSync by not having any at all. Since the update runs every 10 minutes and the push every 30 minutes, slugs that failed to fetch in the last run due to request timeouts will usually get picked up in the next one. The re-fetch every 4 hours will also take care of any plugins that have been closed, which the old tracking logic would not do.
Did you fix any specific issues?
none
CERTIFICATION
By opening this pull request, I do agree to abide by the Code of Conduct and be bound by the terms of the Contribution Guidelines in effect on the date and time of my contribution as proven by the revision information in GitHub.