convert to full Symfony framework #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
still need to do add db migration before i can call this ready. will also add php-cs-fixer while i'm at it. |
|
Excellent future planning for more user friendly UI for people without console access or willingness to learn AS in the console. |
|
Calling this one done: I'll add php-cs-fixer and thecodingmachine/phpstan-safe-rule in a follow-up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What changed?
This converts AspireSync into a full-blown Symfony application instead of a standalone console app. It still works as a standalone console app, but now supports the full symfony suite of functionality.
Why did it change?
Future expansion: we'll want to add an http interface for things like status pages and controlling and monitoring jobs. Stuff like the messenger component will help with job control as well.
Did you fix any specific issues?
Closes: #34
CERTIFICATION
By opening this pull request, I do agree to abide by the Code of Conduct and be bound by the terms of the Contribution Guidelines in effect on the date and time of my contribution as proven by the revision information in GitHub.